1463081 - Instrument inspection of "Edit Rule" in Rule View with event telemetry

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: data-review.txt

Events.yaml:
devtools.main:
  edit_rule:
    objects: ["ruleview"],
    bug_numbers: [1463081]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User is editing a CSS rule by clicking on or next to a rule.
    release_channel_collection: opt-out
    expiry_version: never

Usage:
this.telemetry.recordEvent("devtools.main", "edit_rule", "ruleview");

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1463081 - Instrument inspection of "Edit Rule" in Rule View with event telemetry

The changes to telemetry.js::recordEvent() were necessary because the optional value and extra params cannot be sent to Services.telemetry.recordEvent() as undefined without throwing... using null instead works just fine.

Review commit: https://reviewboard.mozilla.org/r/246422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246422/

Comment 3

[François Marier [:francois]]

Comment on attachment 8979197 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, Events.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Harald Kirschner.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 2

5) Is the data collection request for default-on or default-off?

Default on, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 4

[Yulia Startsev [:yulia] OOO until July 2026]

Comment on attachment 8980260 [details]
Bug 1463081 - Instrument inspection of "Edit Rule" in Rule View with event telemetry

https://reviewboard.mozilla.org/r/246422/#review253520

Looks good!

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b4515cfa30033e12f310467aec49b5840aa8da8f -d d2e3e0b253d2: rebasing 465561:b4515cfa3003 "Bug 1463081 - Instrument inspection of "Edit Rule" in Rule View with event telemetry r=yulia" (tip)
merging devtools/client/inspector/rules/views/rule-editor.js
merging devtools/client/shared/telemetry.js
merging toolkit/components/telemetry/Events.yaml
warning: conflicts while merging devtools/client/inspector/rules/views/rule-editor.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8980260 [details]
Bug 1463081 - Instrument inspection of "Edit Rule" in Rule View with event telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246422/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2139cedcc48
Instrument inspection of "Edit Rule" in Rule View with event telemetry r=yulia

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c2139cedcc48