1463083 - Instrument inspection of inspector side panel switching with event telemetry

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: data-review.txt

Events.yaml:
devtools.main:
  sidepanel_tool_changed:
    objects: ["inspector"],
    bug_numbers: [1463083]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User has switched sidepanel tabs.
    release_channel_collection: opt-out
    expiry_version: never
    extra_keys:
      oldpanel: The panel the user is switching from
      newpanel: The panel the user is switching to

Usage:
this.telemetry.recordEvent("devtools.main", "sidepanel_tool_changed", "inspector", null, {
  oldpanel: "ruleview"
  newpanel: "computedview"
});

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Let's make the name "sidepanel_changed" instead.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1463083 - Instrument inspection of inspector side panel switching with event telemetry

Review commit: https://reviewboard.mozilla.org/r/246434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246434/

Comment 4

[François Marier [:francois]]

Comment on attachment 8979198 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, Events.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Harald Kirschner.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 2

5) Is the data collection request for default-on or default-off?

Default on, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 5

[Yulia Startsev [:yulia]]

Comment on attachment 8980276 [details]
Bug 1463083 - Instrument inspection of inspector side panel switching with event telemetry

https://reviewboard.mozilla.org/r/246434/#review253524

Looks good!

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 6ec537578d5c4cee37df015918ee6deb174abfcf -d d2e3e0b253d2: rebasing 465563:6ec537578d5c "Bug 1463083 - Instrument inspection of inspector side panel switching with event telemetry r=yulia" (tip)
merging devtools/client/inspector/toolsidebar.js
merging toolkit/components/telemetry/Events.yaml
warning: conflicts while merging toolkit/components/telemetry/Events.yaml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8980276 [details]
Bug 1463083 - Instrument inspection of inspector side panel switching with event telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246434/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/375638c8a433
Instrument inspection of inspector side panel switching with event telemetry r=yulia

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/375638c8a433