1463087 - Instrument inspection of JS execution in the Web Console with event telemetry

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: data-review.txt

Events.yaml:
devtools.main:
  execute_js:
    objects: ["webconsole"],
    bug_numbers: [1463083]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User has executed some JS in the Web Console.
    release_channel_collection: opt-out
    expiry_version: never

Usage:
this.telemetry.recordEvent("devtools.main", "execute_js", "webconsole");

Comment 2

[:Harald Kirschner :digitarald]

Please add the number of lines as a key.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to :Harald Kirschner :digitarald from comment #2)
> Please add the number of lines as a key.

So that would be:

Events.yaml:
devtools.main:
  execute_js:
    objects: ["webconsole"],
    bug_numbers: [1463083]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User has executed some JS in the Web Console.
    release_channel_collection: opt-out
    expiry_version: never
    extra_keys:
      lines: The number of lines contained in the command.

Usage:
this.telemetry.recordEvent("devtools.main", "execute_js", "webconsole", null, {
  lines: "1"
});

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1463087 - Instrument inspection of JS execution in the Web Console with event telemetry

Review commit: https://reviewboard.mozilla.org/r/246476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246476/

Comment 5

[François Marier [:francois]]

Comment on attachment 8979200 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, Events.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Harald Kirschner.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 2

5) Is the data collection request for default-on or default-off?

Default on, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 6

[Yulia Startsev [:yulia]]

Comment on attachment 8980327 [details]
Bug 1463087 - Instrument inspection of JS execution in the Web Console with event telemetry

https://reviewboard.mozilla.org/r/246476/#review253536

Looks good

Comment 7

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s bc7f622839f48b5efd3b42bec8dab7aece50ffa5 -d d2e3e0b253d2: rebasing 465565:bc7f622839f4 "Bug 1463087 - Instrument inspection of JS execution in the Web Console with event telemetry r=yulia" (tip)
merging devtools/client/webconsole/components/JSTerm.js
merging toolkit/components/telemetry/Events.yaml
warning: conflicts while merging toolkit/components/telemetry/Events.yaml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8980327 [details]
Bug 1463087 - Instrument inspection of JS execution in the Web Console with event telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246476/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2cbe2403283
Instrument inspection of JS execution in the Web Console with event telemetry r=yulia

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b2cbe2403283

Comment 12

[:Harald Kirschner :digitarald]

ni? Nicolas for prioritization.

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

What's left to do here Harald ?

Comment 14

[:Harald Kirschner :digitarald]

Sorry, bad ni?. Work here is done.