Closed
Bug 1463087
Opened 6 years ago
Closed 6 years ago
Instrument inspection of JS execution in the Web Console with event telemetry
Categories
(DevTools :: General, defect, P2)
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
Comment hidden (obsolete) |
Assignee | ||
Updated•6 years ago
|
Attachment #8979200 -
Flags: review?(andrei.br92) → review?(francois)
Comment 2•6 years ago
|
||
Please add the number of lines as a key.
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to :Harald Kirschner :digitarald from comment #2) > Please add the number of lines as a key. So that would be: Events.yaml: devtools.main: execute_js: objects: ["webconsole"], bug_numbers: [1463083] notification_emails: ["dev-developer-tools@lists.mozilla.org", "hkirschner@mozilla.com"] record_in_processes: ["main"] description: User has executed some JS in the Web Console. release_channel_collection: opt-out expiry_version: never extra_keys: lines: The number of lines contained in the command. Usage: this.telemetry.recordEvent("devtools.main", "execute_js", "webconsole", null, { lines: "1" });
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Depends on: 1463083
Comment hidden (mozreview-request) |
Comment 5•6 years ago
|
||
Comment on attachment 8979200 [details] data-review.txt 1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate? Yes, Events.yaml. 2) Is there a control mechanism that allows the user to turn the data collection on and off? Yes, telemetry setting. 3) If the request is for permanent data collection, is there someone who will monitor the data over time?** Yes, Harald Kirschner. 4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under? ** Category 2 5) Is the data collection request for default-on or default-off? Default on, all channels. 6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? No. 7) Is the data collection covered by the existing Firefox privacy notice? Yes. 8) Does there need to be a check-in in the future to determine whether to renew the data? No, permanent.
Attachment #8979200 -
Flags: review?(francois) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8980327 [details] Bug 1463087 - Instrument inspection of JS execution in the Web Console with event telemetry https://reviewboard.mozilla.org/r/246476/#review253536 Looks good
Attachment #8980327 -
Flags: review?(ystartsev) → review+
Comment 7•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s bc7f622839f48b5efd3b42bec8dab7aece50ffa5 -d d2e3e0b253d2: rebasing 465565:bc7f622839f4 "Bug 1463087 - Instrument inspection of JS execution in the Web Console with event telemetry r=yulia" (tip) merging devtools/client/webconsole/components/JSTerm.js merging toolkit/components/telemetry/Events.yaml warning: conflicts while merging toolkit/components/telemetry/Events.yaml! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2cbe2403283 Instrument inspection of JS execution in the Web Console with event telemetry r=yulia
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b2cbe2403283
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 13•6 years ago
|
||
What's left to do here Harald ?
Flags: needinfo?(nchevobbe) → needinfo?(hkirschner)
You need to log in
before you can comment on or make changes to this bug.
Description
•