Closed Bug 1463088 Opened Last year Closed Last year

Possibly unnecessary self-assign in browser/base/content/test/plugins/head.js & browser_plugin_reloading.js

Categories

(Core :: Plug-ins, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

This is being picked up by ESLint 5 which we haven't got in the tree yet, but I'm testing out the early versions.

browser/base/content/test/plugins/browser_plugin_reloading.js
  69:18  error  'plugin.src' is assigned to itself.  no-self-assign (eslint)

browser/base/content/test/plugins/head.js
  177:18  error  'plugin.src' is assigned to itself.  no-self-assign (eslint)

https://searchfox.org/mozilla-central/rev/8affe6e83188787eb61fe0528eeb6eef6081ba06/browser/base/content/test/plugins/head.js#177

These seem to have been added by bug 1129040.

We could whitelist them, or remove them, however there's no comments about why they're assigning to self, which makes me a bit wary about picking one.

Jim any ideas?
Flags: needinfo?(jmathies)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaaa2b5bfa61a5f23069b3caf0d9ae0d6f95e25c

these are probably needed, but let find out.
Flags: needinfo?(jmathies)
Looks like these are needed, I'll whiltelist them.
Assignee: nobody → standard8
Comment on attachment 8984124 [details]
Bug 1463088 - Whitelist self-assigns in browser/base/content/test/plugins/ ready for the next version of ESLint.

https://reviewboard.mozilla.org/r/249950/#review256352
Attachment #8984124 - Flags: review?(jmathies) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf083b3c02c7
Whitelist self-assigns in browser/base/content/test/plugins/ ready for the next version of ESLint. r=jimm
https://hg.mozilla.org/mozilla-central/rev/bf083b3c02c7
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.