1463103 - The FontMeta component does not highlight text-runs on hover when it is in the FontEditor component

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1463103 - Highlight text-runs even in the FontEditor;

Review commit: https://reviewboard.mozilla.org/r/245438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245438/

Comment 2

[Patrick Brosset <:pbro>]

I was testing bug 1463055 when I detected this bug (so the patches from that bug need to be applied locally).
The bug isn't visible to end users by default, but generates a JS error in the browser console.
STR:
- have devtools.inspector.fonthighlighter.enabled set to true
- open the inspector and the Fonts tab
- select an element in a page and check that the Fonts panel does display something
- hover over the name of the font, at the top of the panel
==> in the browser console, an error about onToggleFontHighlight being undefined is logged

Comment 3

[Razvan Caliman [:rcaliman]]

Comment on attachment 8979209 [details]
Bug 1463103 - Highlight text-runs even in the FontEditor;

https://reviewboard.mozilla.org/r/245438/#review251408

Looks good to me.

Comment 4

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1463103 - Font Highlighter: Default isForCurrentElement to true and cleanup from component props.

Review commit: https://reviewboard.mozilla.org/r/245454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245454/

Comment 5

[Patrick Brosset <:pbro>]

Comment on attachment 8979234 [details]
Bug 1463103 - Font Highlighter: Default isForCurrentElement to true and cleanup from component props.

Thanks Razvan for the cleanup!
As discussed on Slack, let me pull that in and squash it with my original commit.

Comment 6

[Patrick Brosset <:pbro>]

Comment on attachment 8979209 [details]
Bug 1463103 - Highlight text-runs even in the FontEditor;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245438/diff/1-2/

Comment 7

[Patrick Brosset <:pbro>]

Comment on attachment 8979234 [details]
Bug 1463103 - Font Highlighter: Default isForCurrentElement to true and cleanup from component props.

Forgot to actually obsolete this patch.

Comment 8

[Patrick Brosset <:pbro>]

Comment on attachment 8979209 [details]
Bug 1463103 - Highlight text-runs even in the FontEditor;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245438/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/455b34e35cd1
Highlight text-runs even in the FontEditor; r=rcaliman

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/455b34e35cd1