1463144 - Instrument inspection of "Filter changes" in the Network Panel with event telemetry

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: data-review.txt

We already have the following event:
devtools.main:
  filter_changed:
    objects: ["webconsole"],
    bug_numbers: [1463095]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User has changed a filter in the web console.
    release_channel_collection: opt-out
    expiry_version: never
    extra_keys:
      clicked: "The clicked filter: error, warn, log, info, debug, css, netxhr or net"
      active: Comma separated list of active filters.
      inactive: Comma separated list of inactive filters.

So we would need to add:
devtools.main::filter_changed::objects = ["netmonitor", "webconsole"]
devtools.main::filter_changed::extra_keys:click = "The clicked filter: error, warn, log, info, debug, css, netxhr or net for webconsole and all, html, css, js, xhr, fonts, images, media, ws or other for netmonitor"

Usage:
this.telemetry.recordEvent("devtools.main", "filter_changed", "netmonitor", null, {
  clicked: "html"
  active: "css,js,xhr,fonts,images,media,ws,other"
  inactive: "html"
});

Comment 2

[François Marier [:francois]]

Comment on attachment 8979251 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, Events.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Harald Kirschner.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 2

5) Is the data collection request for default-on or default-off?

Default on, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We already have the following event:
devtools.main:
  filter_changed:
    objects: ["webconsole"]
    bug_numbers: [1463095]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User has changed a filter in the web console.
    release_channel_collection: opt-out
    expiry_version: never
    extra_keys:
      clicked: "The clicked filter: error, warn, log, info, debug, css, netxhr or net"
      active: Comma separated list of active filters.
      inactive: Comma separated list of inactive filters.
      session_id: The toolbox session start time e.g. 13963.

So we would need to add:
devtools.main::filter_changed::objects = ["netmonitor", "webconsole"]
devtools.main::filter_changed::extra_keys:clicked = "The clicked filter: error, warn, log, info, debug, css, netxhr or net for webconsole and all, html, css, js, xhr, fonts, images, media, ws or other for netmonitor"

Usage:
this.telemetry.recordEvent("devtools.main", "filter_changed", "netmonitor", null, {
  clicked: "html"
  active: "css,js,xhr,fonts,images,media,ws,other"
  inactive: "html",
  "session_id": toolbox.sessionId
}

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1463144 - Instrument inspection of "Filter changes" in the Network Panel with event telemetry

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8999581 [details]
Bug 1463144 - Instrument inspection of "Filter changes" in the Network Panel with event telemetry

Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0af5942407da
Instrument inspection of "Filter changes" in the Network Panel with event telemetry r=miker

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0af5942407da