146315 - nsIAccessible's accDoAction does not work for XUL Button Element.

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[dsirnapalli]

Similar bug has been filed for HTML Button Node. Bug#124234
-- When i called nsIAccessible's accDoAction on XUL Button Node the button is
not getting clicked.
In the attached test case i added an onclick event listener for the button
--domNode.addEventListener('click', nodeClicked,true);
The statement
accNode.accDoAction(0);
should click the button.
If the button gets actually clicked the last alert should be "Button Pressed".

Comment 1

[dsirnapalli]

Attachment: Testcase to reproduce the bug

Comment 2

[dsirnapalli]

Attachment: Test case to reproduce the bug

-- for the previous attachment i gave mime type as text/html. so i had to
reattach the test case with mime type as xul.

Comment 3

[Kyle Yuan]

investigated :
1) Can not test by clicking testcase's link, must "View Page Source", then save 
it as a XML file, drag into mozilla.
2) "View Page Source" can not display the page source content correctly.

Comment 4

[Kyle Yuan]

sorry, I use this previous test case.

Jessie, this XUL test case will help your work.

Comment 5

[Kyle Yuan]

Attachment: patch (change buttonElement->DoCommand() to buttonElement->Click())

There are maybe some potential errors of XULCheckbox and XULRadio's
accDoAction.
Dharma, could make test cases for above XUL widgets too? We can fix all the
bugs of button widget's doAction at once.

Comment 6

[dsirnapalli]

-- sure, i can do that. i need time till monday or so.

Comment 7

[dsirnapalli]

-- I filed a seperate bug for XUL Checkbox Node. Bug#146499. Because the problem
might be different in case of XUL Checkbox Node. In case of checkbox node i see
that the checkbox is actually clicked but the event is not getting fired. I dont
know what's the case with button(whether it is actually getting clicked or not).

Comment 8

[Kyle Yuan]

Yes, the problems are different, but the fix is same :)

need r=

Comment 9

[Aaron Leventhal]

Perhaps the right way to fix this is to make DoCommand() work correctly?

Comment 10

[Kyle Yuan]

See:
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/b
utton.xml#76

DoCommand do nothing for Button. Even if we modified this handler to let it 
work for button, I'm not sure whether a proper event will be fired?

Comment 11

[Aaron Leventhal]

Comment on attachment 84715 [details] [diff] [review]
patch (change buttonElement->DoCommand() to buttonElement->Click())

r=aaronl

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 84715 [details] [diff] [review]
patch (change buttonElement->DoCommand() to buttonElement->Click())

sr=jst

Comment 13

[Kyle Yuan]

checked in.

Comment 14

[dsirnapalli]

-- verified in current nightly build. works fine. marking bug as verified.