1463169 - Instrument inspection of "sidebar changed" in the Network Panel with event telemetry

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: data-review.txt

We already have this:

Events.yaml:
devtools.main:
  sidepanel_tool_changed:
    objects: ["inspector"],
    bug_numbers: [1463083]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User has switched sidepanel tabs.
    release_channel_collection: opt-out
    expiry_version: never
    extra_keys:
      oldpanel: The panel the user is switching from
      newpanel: The panel the user is switching to


So we would just need to add devtools.main::sidepanel_tool_changed::objects = ["inspector", "netmonitor"]

Usage:
this.telemetry.recordEvent("devtools.main", "sidepanel_tool_changed", "netmonitor", null, {
  oldpanel: "headers"
  newpanel: "cookies"
});

Comment 2

[François Marier [:francois]]

Comment on attachment 8979279 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, Events.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Harald Kirschner.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 2

5) Is the data collection request for default-on or default-off?

Default on, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We already have this:

Events.yaml:
devtools.main:
  sidepanel_tool_changed:
    objects: ["inspector"],
    bug_numbers: [1463083]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User has switched sidepanel tabs.
    release_channel_collection: opt-out
    expiry_version: never
    extra_keys:
      oldpanel: The panel the user is switching from
      newpanel: The panel the user is switching to
      session_id: The toolbox session start time e.g. 13963.

So we would just need to add devtools.main::sidepanel_tool_changed::objects = ["inspector", "netmonitor"]

Usage:
this.telemetry.recordEvent("devtools.main", "sidepanel_tool_changed", "netmonitor", null, {
  "oldpanel": "headers",
  "newpanel": "cookies",
  "session_id": toolbox.sessionId
});

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1463169 - Instrument inspection of "sidebar changed" in the Network Panel with event telemetry

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8999671 [details]
Bug 1463169 - Instrument inspection of "sidebar changed" in the Network Panel with event telemetry

Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6181783d973c
Instrument inspection of "sidebar changed" in the Network Panel with event telemetry r=miker

Comment 7

[Tiberius Oros[:tiberius_oros]]

Backed out changeset 6181783d973c (bug 1463169) for eslint failure at builds/worker/checkouts/gecko/devtools/client/netmonitor/src/middleware/event-telemetry.js

Backout:
https://hg.mozilla.org/integration/autoland/rev/9ebc9e26c37a9656d3a9015646739e983b6dd405

Push with the failure:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6181783d973c1927d7e63f2ef9a5dbe9d9541b05&selectedJob=193858381

Failure log file:
https://treeherder.mozilla.org/logviewer.html#?job_id=193858381&repo=autoland&lineNumber=263

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4fa7f833102
Instrument inspection of "sidebar changed" in the Network Panel with event telemetry r=miker

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Relanded

Honza

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a4fa7f833102