1463207 - use `serviceName` instead of `name` in reference data

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-client/pull/95/commits/3bca5ac501f3fe48b3a03873aa2115f443251a07 for tc-client

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-lib-api/pull/99

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

As near as I can tell, the other client's don't use `name`, so no need to change them to use `serviceName`.  I suspect that will come with Brian's work to bring them into the rootUrl-y world.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-lib-api

https://github.com/taskcluster/taskcluster-lib-api/commit/7bc9f431b77b346976cec1a7fb76754437841973
Bug 1463207 - use serviceName instead of name (#99)

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-secrets/pull/40

Comment 6

[Pete Moore [:pmoore][:pete]]

This seems to have broken aws-provisioner and ec2-manager.

Comment 7

[Pete Moore [:pmoore][:pete]]

oh, and login service...


Document 'https://references.taskcluster.net/auth/v1/api.json' is valid against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.
Document 'https://references.taskcluster.net/auth/v1/exchanges.json' is valid against 'http://schemas.taskcluster.net/base/v1/exchanges-reference.json#'.
Document 'https://references.taskcluster.net/aws-provisioner/v1/api.json' is INVALID against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.

- serviceName: serviceName is required

- name: Additional property name is not allowed
Document 'https://references.taskcluster.net/aws-provisioner/v1/exchanges.json' is valid against 'http://schemas.taskcluster.net/base/v1/exchanges-reference.json#'.
Document 'https://references.taskcluster.net/ec2-manager/v1/api.json' is INVALID against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.

- serviceName: serviceName is required

- entries.1.scopes: Must validate one and only one schema (oneOf)

- entries.1.scopes: Invalid type. Expected: string, given: array

- entries.2.scopes: Must validate one and only one schema (oneOf)

- entries.2.scopes: Invalid type. Expected: string, given: array

- entries.7.scopes: Must validate one and only one schema (oneOf)

- entries.7.scopes: Invalid type. Expected: string, given: array

- entries.8.scopes: Must validate one and only one schema (oneOf)

- entries.8.scopes: Invalid type. Expected: string, given: array

- entries.9.scopes: Must validate one and only one schema (oneOf)

- entries.9.scopes: Invalid type. Expected: string, given: array

- entries.14.scopes: Must validate one and only one schema (oneOf)

- entries.14.scopes: Invalid type. Expected: string, given: array

- entries.15.scopes: Must validate one and only one schema (oneOf)

- entries.15.scopes: Invalid type. Expected: string, given: array

- entries.16.scopes: Must validate one and only one schema (oneOf)

- entries.16.scopes: Invalid type. Expected: string, given: array

- entries.17.scopes: Must validate one and only one schema (oneOf)

- entries.17.scopes: Invalid type. Expected: string, given: array

- entries.18.scopes: Must validate one and only one schema (oneOf)

- entries.18.scopes: Invalid type. Expected: string, given: array

- entries.19.scopes: Must validate one and only one schema (oneOf)

- entries.19.scopes: Invalid type. Expected: string, given: array

- entries.20.scopes: Must validate one and only one schema (oneOf)

- entries.20.scopes: Invalid type. Expected: string, given: array
Document 'https://references.taskcluster.net/github/v1/api.json' is valid against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.
Document 'https://references.taskcluster.net/github/v1/exchanges.json' is valid against 'http://schemas.taskcluster.net/base/v1/exchanges-reference.json#'.
Document 'https://references.taskcluster.net/hooks/v1/api.json' is valid against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.
Document 'https://references.taskcluster.net/index/v1/api.json' is valid against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.
Document 'https://references.taskcluster.net/login/v1/api.json' is INVALID against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.

- serviceName: serviceName is required

- name: Additional property name is not allowed
Document 'https://references.taskcluster.net/notify/v1/api.json' is valid against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.
Document 'https://references.taskcluster.net/purge-cache/v1/api.json' is valid against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.
Document 'https://references.taskcluster.net/purge-cache/v1/exchanges.json' is valid against 'http://schemas.taskcluster.net/base/v1/exchanges-reference.json#'.
Document 'https://references.taskcluster.net/queue/v1/api.json' is valid against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.
Document 'https://references.taskcluster.net/queue/v1/exchanges.json' is valid against 'http://schemas.taskcluster.net/base/v1/exchanges-reference.json#'.
Document 'https://references.taskcluster.net/secrets/v1/api.json' is valid against 'http://schemas.taskcluster.net/base/v1/api-reference.json#'.
Document 'https://references.taskcluster.net/taskcluster-treeherder/v1/exchanges.json' is valid against 'http://schemas.taskcluster.net/base/v1/exchanges-reference.json#'.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Can you explain what "broken" means here?  There were 45-odd days between this bug closing and the "breakage" during which time all of those services were working :)

Comment 9

[Pete Moore [:pmoore][:pete]]

Sorry, to be clear, I meant it broke the taskcluster client go code generation, that was important information I should have mentioned!

We now have other bugs open for the schema issues (e.g. bug 1484923) - so I think we can leave this closed.