1463210 - Missing edge in call graph from JSRope::copyChars

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

It calls JSRope::copyCharsLatin1, and that shows up in the .xdb file.

Oh... looking at it, I'm seeing both

#277266 = uint8 JSRope::copyChars(JSContext*, struct js::ScopedJSFreePtr<unsigned char>*) const [with CharT = unsigned char] (5 callers)
#15918 = uint8 JSRope::copyChars(struct JSContext*, struct js::ScopedJSFreePtr<unsigned char>*) const [with CharT = unsigned char] (0 callers)

which looks like it's a mismatch in whether it has a 'struct' prefix on the JSContext* argument type. I thought I fixed that in sixgill with https://hg.mozilla.org/users/sfink_mozilla.com/sixgill/739c064cd73c but I guess there's another case lurking.

Comment 1

[Steve Fink [:sfink] [:s:]]

This was fixed with a patch to sixgill, 22cb1549268b. It doesn't seem worth bothering with a review, and I've been running with it for 6 months or so.