1463223 - Check if the autocomplete popup is initialized before performing any action in the rule view

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

We lazy loaded the autocomplete popup in the rule view in Bug 1459027, but we call this.popup which initializes the autocomplete popup every time we select an element in the rule view, so we don't really benefit from the lazy loading of the autocomplete popup right now. 

We should check this._popup to make sure we don't do anything with the autocomplete popup if it isn't even initialized and isn't needed yet.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1463223 - Check if the autocomplete popup is initialized before performing any action in the rule view.

Review commit: https://reviewboard.mozilla.org/r/245508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245508/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

baseline https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=215eaff7949eb78d0d5eef13dc1d22336014c20f
mochitest-dt talos https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=50e87a12b0791a189b5a296d8de435613101cd0d

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8979349 [details]
Bug 1463223 - Check if the autocomplete popup is initialized before performing any action in the rule view.

https://reviewboard.mozilla.org/r/245508/#review251696

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea25cc1e2c52
Check if the autocomplete popup is initialized before performing any action in the rule view. r=pbro

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ea25cc1e2c52