1463351 - Mouse event handlers shouldn't handle non-primary mouse buttons

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:
 1. Run Firefox Nightly 62.0a1 (2018-05-14) (64-bit)
 2. enable auto-scrolling in Firefox preferences (about:preferences#general - Use autoscrolling)
 3. open Phabricator diff view (for example: https://phabricator.services.mozilla.com/D1 )
 4. hover onto line number in diff view (for example: HACKING.md line 1 above)
 5. start auto scroll from there, by pressing middle mouse button and move cursor

Actual result:
  auto scroll starts,
  and dragged lines are selected and comment form is opened when releasing middle mouse button

Expected result:
  auto scroll starts,
  and nothing happens on page itself

Comment 1

[Mark Côté [:mcote]]

I'd like to wait until autoscrolling gets closer to release before contacting upstream about this.

Comment 2

[Tooru Fujisawa [:arai]]

the issue is not specific to autoscroll, but all non-primary button events.
web application should check which button is used, and only respond to specific button (especially for primary button).

Comment 3

[Tooru Fujisawa [:arai]]

(In reply to Mark Côté [:mcote] from comment #1)
> I'd like to wait until autoscrolling gets closer to release before
> contacting upstream about this.

does it mean I'd better avoid filing a bug upstream until then?

Comment 4

[Mark Côté [:mcote]]

We have a support contract with them, which is generally a better way to report things (has a higher chance of being prioritized).  Has auto-scrolling been released yet?

Comment 5

[Tooru Fujisawa [:arai]]

(In reply to Mark Côté [:mcote] from comment #4)
> Has auto-scrolling been released yet?

if you mean whether it's available on release channel, yes,
"Use autoscrolling" is inside about:preferences, "General" pane, "Browsing" section, and it's enabled by default,
on Firefox 63.0.3 (64-bit), with clean profile, on macOS.
(sorry my wording in the comment #0 was misleading that it sounds like it needs to be enabled manually.  I meant "make sure it's enabled")

it's also true for windows.
on other unix/linux, it's disabled by default.

https://searchfox.org/mozilla-central/rev/c0b26c40769a1e5607a1ae8be37fe64df64fc55e/browser/app/profile/firefox.js#209-213


it has been enabled by default for more than 15 years.

https://github.com/mozilla/gecko-dev/commit/bd32ca4753006facad5412b143afb03ecf86a8f3
https://github.com/mozilla/gecko-dev/commit/e1b3204886e0400bbfa8187693449358f0d0ceff

Comment 6

[Mark Côté [:mcote]]

I got an update from upstream; they agree it's a bug and will be fixing this.  No link to an issue yet, but I'll monitor the changelog and close it out when I see it landing.

Comment 7

[:glob ✱]

looks like this was fixed.