Split console's close [x] button should be right aligned (without margin/padding right)

RESOLVED FIXED in Firefox 61

Status

defect
P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: nachtigall, Assigned: daisuke)

Tracking

61 Branch
Firefox 62
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox61 fixed, firefox62 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
The split console's close button has the same problem like the normal DevTools' close button had: There's a right margin/padding of 3, 4 pixels making it impossible to just sloppily hit the close button by moving the mouse to the outmost right.

At least in Windows 10. See bug 1455589 on how it was fixed there. The same should be applied for the console split button.
(Reporter)

Updated

a year ago
Assignee: nobody → mantaroh
Blocks: 1444302
Priority: -- → P3
(Assignee)

Comment 1

a year ago
Let me steal this bug.
Assignee: mantaroh → dakatsuka

Comment 3

a year ago
mozreview-review
Comment on attachment 8979824 [details]
Bug 1463355: Remove right margin/padding from split console close button in case of the platform is not 'mac'.

https://reviewboard.mozilla.org/r/245994/#review252034

::: devtools/client/themes/webconsole.css:565
(Diff revision 1)
> +:root[platform="mac"] .split-console-close-button-wrapper {
> +  padding-inline-end: 3px;
> +}

why is there a special treatment for mac ? If it is needed, can we add a comment explaining why ?

::: devtools/client/themes/webconsole.css:571
(Diff revision 1)
> +  padding-inline-end: 3px;
> +}
> +
> +#split-console-close-button {
> +  margin-inline-end: 0;
> +  padding-inline-end: 0;

I think the concern raised by the reporter is that he want to be able to click when puttin the mouse at the top right corner basically.
So, I think we can keep the padding as it expand the click target.
Attachment #8979824 - Flags: review?(nchevobbe) → review-
(Assignee)

Comment 4

a year ago
mozreview-review-reply
Comment on attachment 8979824 [details]
Bug 1463355: Remove right margin/padding from split console close button in case of the platform is not 'mac'.

https://reviewboard.mozilla.org/r/245994/#review252034

> why is there a special treatment for mac ? If it is needed, can we add a comment explaining why ?

Thank you for the reviewing, Nicolas!

It's for consistency with toolbox pane.
https://searchfox.org/mozilla-central/source/devtools/client/themes/toolbox.css#169
I'll add a comment here.

> I think the concern raised by the reporter is that he want to be able to click when puttin the mouse at the top right corner basically.
> So, I think we can keep the padding as it expand the click target.

Okay, leave as it is.
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8979824 [details]
Bug 1463355: Remove right margin/padding from split console close button in case of the platform is not 'mac'.

https://reviewboard.mozilla.org/r/245994/#review252130

Thanks Daisuke !
I played with it for a bit and it looks good to me :)
Attachment #8979824 - Flags: review?(nchevobbe) → review+
(Assignee)

Comment 7

a year ago
mozreview-review-reply
Comment on attachment 8979824 [details]
Bug 1463355: Remove right margin/padding from split console close button in case of the platform is not 'mac'.

https://reviewboard.mozilla.org/r/245994/#review252130

Thanks Nicolas!
I'll make this patch to land!

Comment 8

a year ago
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55fba2421083
Remove right margin/padding from split console close button in case of the platform is not 'mac'. r=nchevobbe

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/55fba2421083
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Comment on attachment 8979824 [details]
Bug 1463355: Remove right margin/padding from split console close button in case of the platform is not 'mac'.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1444302
[User impact if declined]: As mentioned bug 1455589 comment 0, some user expected that most-right button will close the window. So those kind of user will feel hard to use.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: bug 1444302
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is only the change of styles.
[String changes made/needed]: N/A
Attachment #8979824 - Flags: approval-mozilla-beta?
Comment on attachment 8979824 [details]
Bug 1463355: Remove right margin/padding from split console close button in case of the platform is not 'mac'.

CSS fix needed to support bug 1444302. Approved for 61.0b10.
Attachment #8979824 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.