Split console's close [x] button should have tooltip showing Esc shortcut

RESOLVED FIXED in Firefox 63

Status

enhancement
P3
normal
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: nachtigall, Assigned: mantaroh)

Tracking

61 Branch
Firefox 63

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
The split console's button has no tooltip atm. But it should have because knowing that you can toggle it with [ESC] is very valuable. I'd suggest you add something like:

"Close console split (Esc)" as title so it will show as tooltip. 

Also important for accessibility.

(BTW: the DevTools close button tooltip could also be changed from "Close Developer Tools" to "Close Developer Tools (F12)". Adding another bug this?)
(Reporter)

Updated

11 months ago
Assignee: nobody → mantaroh
Blocks: 1444302
Priority: -- → P3

Updated

10 months ago
Product: Firefox → DevTools
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8991509 [details]
Bug 1463357 - Add tooltip to the console button of split console and sidebar.

https://reviewboard.mozilla.org/r/256406/#review263286


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/locales/en-US/webconsole.properties:281
(Diff revision 1)
>  # current inspected page is navigated to a new location.
>  # Parameters: %S is the new URL.
>  webconsole.navigated=Navigated to %S
> +
> +# LOCALIZATION NOTE (webconsole.closeSplitConsoleButton.tooltip): This is the tooltip for
> +# the close button ofthe split console.

Warning: Ofthe  ==> of the [codespell]
Comment hidden (mozreview-request)

Comment 4

10 months ago
mozreview-review
Comment on attachment 8991509 [details]
Bug 1463357 - Add tooltip to the console button of split console and sidebar.

https://reviewboard.mozilla.org/r/256406/#review263318

Thanks for the patch Mantaroh, and additional thanks for the tooltip on the sidebar close button !
I tested the patch and everything looks fine. Let's land this :)
Attachment #8991509 - Flags: review?(nchevobbe) → review+
(Assignee)

Comment 5

10 months ago
mozreview-review-reply
Comment on attachment 8991509 [details]
Bug 1463357 - Add tooltip to the console button of split console and sidebar.

https://reviewboard.mozilla.org/r/256406/#review263318

Thanks!

The try build looks green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76535752d2a05ffa592ef19238685ba9cc11bc11

Comment 6

10 months ago
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/49707eda3179
Add tooltip to the console button of split console and sidebar. r=nchevobbe

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/49707eda3179
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.