1463416 - Update webrender to 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1462611 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1463416 - Update webrender to cset 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641.

Review commit: https://reviewboard.mozilla.org/r/245690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245690/

Comment 2

[Darkspirit]

wrong bug?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Whoops, thanks for catching that!

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ bb354abbf84602d3d8357c63c4f0b1139ec4deb1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f35c05b7ab60575105bbb95aeab4e436b010ffbe
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a28456ce030fcda1b946686e1e713f40f5936999
https://treeherder.mozilla.org/#/jobs?repo=try&revision=088c12c9a27952f8cb04dc4477c82dc5b3394aa4

Nothing new here

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ bb354abbf84602d3d8357c63c4f0b1139ec4deb1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=10f67562839872a3f96d0c09cb00ba490eb3a4d0

Same

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ bb354abbf84602d3d8357c63c4f0b1139ec4deb1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5c58d0cf97b8df6c9b683766b69705bf618bc5d

Same

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 5084aae77720ce6f3aedb43a31a054b729fdb398

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8504f562c9f20884ebbddac231a3800ac2b17e0a

Green so far

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 523575ecb10126070903abb8215cafcaa9ec05a6

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0f2f20256c28f9c956323ed99d4f56bbd1bd58a

Reftests that need fuzzing, from servo/webrender#2767. Otherwise looks ok so far.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ 4b9263088971b43e386b0ce9db92e9edf0abff99 with patch from bug 1458921:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f163bdabcdb0b687c5aac65ff36f46f34102a4a

Linux and windows are green, but there's a lot of macOS reftest changes.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

The servo/webrender#2777 also broke my update process. Try pushes on hold until I sort that out.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

WR @ 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641, with serde fixups

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fefd349b4ad47127ae573166ff8d306b997e64f

What's done looks about the same as before.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

After a week of no WR changes everybody decided to land their API-changing PRs all at once. It's getting really convoluted to manage so I'm going to do an update to 63c71ca9 rather than master.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

WR @ 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd511599e052e4046a6aa2db8bd78a55da10b82c

This has the updated patch from bug 1458921. Hopefully it's green.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Not green yet. With the latest from bug 1458921:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c20e39429e781e779522910f81e9cba6c90f475e

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Still one unexpected-pass on windows. An earlier patch from bug 1458921 had taken care of this but it looks like it got accidentally reverted somewhere along the way.

Final try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9901ec3c5bb2858326a2f571e17a4ae668dc1d1

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1463416 - Update lockfiles and re-vendor rust dependencies.

This includes the necessary changes for the serde replacement upgrade from
WR PR 2777 as well.

Review commit: https://reviewboard.mozilla.org/r/247032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247032/

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1463416 - Update for API changes in WR PR 2718.

Review commit: https://reviewboard.mozilla.org/r/247034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247034/

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1463416 - Update reftest annotations for changes in WR PR 2767.

Review commit: https://reviewboard.mozilla.org/r/247036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247036/

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1463416 - use new WR subpixel positioning API from WR PR 2738.

Patch originally developed on bug 1458921 but needs to land with the WR update.

Review commit: https://reviewboard.mozilla.org/r/247038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247038/

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8979537 [details]
Bug 1463416 - Update webrender to cset 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245690/diff/1-2/

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Rebased to a more recent m-c tip: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0792c3cf0b1b77bcdf6a89454f025b5dcb024cf

Comment 22

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8979537 [details]
Bug 1463416 - Update webrender to cset 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245690/diff/2-3/

Comment 23

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8980839 [details]
Bug 1463416 - Update lockfiles and re-vendor rust dependencies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247032/diff/1-2/

Comment 24

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8980840 [details]
Bug 1463416 - Update for API changes in WR PR 2718.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247034/diff/1-2/

Comment 25

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8980841 [details]
Bug 1463416 - Update reftest annotations for changes in WR PR 2767.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247036/diff/1-2/

Comment 26

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8980842 [details]
Bug 1463416 - use new WR subpixel positioning API from WR PR 2738.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247038/diff/1-2/

Comment 27

[Kartikaya Gupta (email:[e-mail])]

In https://treeherder.mozilla.org/logviewer.html#?job_id=180401256&repo=try it appears that the fuzz from servo/webrender#2767 has a slightly wider range, it's not 100% consistent from run to run. I'll need to expand the fuzzy range a bit.

Comment 28

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8979537 [details]
Bug 1463416 - Update webrender to cset 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245690/diff/3-4/

Comment 29

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8980839 [details]
Bug 1463416 - Update lockfiles and re-vendor rust dependencies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247032/diff/2-3/

Comment 30

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8980840 [details]
Bug 1463416 - Update for API changes in WR PR 2718.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247034/diff/2-3/

Comment 31

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8980841 [details]
Bug 1463416 - Update reftest annotations for changes in WR PR 2767.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247036/diff/2-3/

Comment 32

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8980842 [details]
Bug 1463416 - use new WR subpixel positioning API from WR PR 2738.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247038/diff/2-3/

Comment 33

[Aria Beingessner [:Gankra]]

Comment on attachment 8979537 [details]
Bug 1463416 - Update webrender to cset 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641.

https://reviewboard.mozilla.org/r/245690/#review253206

Comment 34

[Aria Beingessner [:Gankra]]

Comment on attachment 8980841 [details]
Bug 1463416 - Update reftest annotations for changes in WR PR 2767.

https://reviewboard.mozilla.org/r/247036/#review253208

Comment 35

[Aria Beingessner [:Gankra]]

Comment on attachment 8980839 [details]
Bug 1463416 - Update lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/247032/#review253210

Comment 36

[Aria Beingessner [:Gankra]]

Comment on attachment 8980842 [details]
Bug 1463416 - use new WR subpixel positioning API from WR PR 2738.

https://reviewboard.mozilla.org/r/247038/#review253212

deja-vu... didn't lsalzman already land this..?

Comment 37

[Nicolas Silva [:nical]]

Comment on attachment 8980840 [details]
Bug 1463416 - Update for API changes in WR PR 2718.

https://reviewboard.mozilla.org/r/247034/#review253244

Comment 38

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2e3cbd5aeca
Update webrender to cset 63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/52e2d7efe721
Update lockfiles and re-vendor rust dependencies. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/20d0acbdc894
Update for API changes in WR PR 2718. r=nical
https://hg.mozilla.org/integration/autoland/rev/fa600f06d421
Update reftest annotations for changes in WR PR 2767. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/6e93883796aa
use new WR subpixel positioning API from WR PR 2738. r=Gankro

Comment 39

[Kartikaya Gupta (email:[e-mail])]

(In reply to Alexis Beingessner [:Gankro] from comment #36)
> deja-vu... didn't lsalzman already land this..?

It didn't land because it needed to land with the WR update changes. i.e. in this bug.

Comment 40

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b2e3cbd5aeca
https://hg.mozilla.org/mozilla-central/rev/52e2d7efe721
https://hg.mozilla.org/mozilla-central/rev/20d0acbdc894
https://hg.mozilla.org/mozilla-central/rev/fa600f06d421
https://hg.mozilla.org/mozilla-central/rev/6e93883796aa

Comment 41

[Cosmin Sabou [:CosminS]]

Hi, since the fix for this bug landed here http://tinyurl.com/y7u2u3l6, bug 1418778 started to almost permafail: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=Linux%20x64%20QuantumRender%20op%20wdspec&fromchange=6e93883796aaffd17c2e0b387bd758749640ce66&selectedJob=180561241&filter-resultStatus=success&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=180561241&repo=autoland&lineNumber=43044

[task 2018-05-28T13:41:37.173Z] 13:41:37     INFO - STDOUT: tests/web-platform/tests/webdriver/tests/new_session/create_alwaysMatch.py::test_valid[test:extension-None] 
[task 2018-05-28T13:41:37.174Z] 13:41:37     INFO - PID 5559 | 1527514897167	webdriver::server	DEBUG	<- 200 OK {"value": {}}
[task 2018-05-28T13:41:37.177Z] 13:41:37     INFO - PID 5559 | 1527514897171	webdriver::server	DEBUG	-> POST /session {"capabilities": {"alwaysMatch": {"moz:firefoxOptions": {"binary": "/builds/worker/workspace/build/application/firefox/firefox", "prefs": {"network.dns.localDomains": "xn--lve-6lad.not-web-platform.test,xn--lve-6lad.web-platform.test,xn--n8j6ds53lwwkrqhv28a.not-web-platform.test,www1.web-platform.test,www2.web-platform.test,not-web-platform.test,web-platform.test,www2.not-web-platform.test,www1.not-web-platform.test,www.not-web-platform.test,www.web-platform.test,xn--n8j6ds53lwwkrqhv28a.web-platform.test"}}, "test:extension": null}}}
[task 2018-05-28T13:41:37.177Z] 13:41:37     INFO - PID 5559 | 1527514897174	mozrunner::runner	INFO	Running command: "/builds/worker/workspace/build/application/firefox/firefox" "-marionette" "-profile" "/tmp/rust_mozprofile.etfY0jPwoNaT"
[task 2018-05-28T13:41:37.179Z] 13:41:37     INFO - PID 5559 | 1527514897177	geckodriver::marionette	DEBUG	Waiting 60s to connect to browser on 127.0.0.1:2828
[task 2018-05-28T13:41:37.841Z] 13:41:37     INFO - PID 5559 | 1527514897836	Marionette	DEBUG	Received observer notification profile-after-change
[task 2018-05-28T13:41:37.917Z] 13:41:37     INFO - PID 5559 | ATTENTION: default value of option force_s3tc_enable overridden by environment.
[task 2018-05-28T13:41:37.953Z] 13:41:37     INFO - PID 5559 | 1527514897947	Marionette	DEBUG	Received observer notification command-line-startup
[task 2018-05-28T13:41:37.954Z] 13:41:37     INFO - PID 5559 | 1527514897947	Marionette	DEBUG	Received observer notification nsPref:changed
[task 2018-05-28T13:41:37.954Z] 13:41:37     INFO - PID 5559 | 1527514897947	Marionette	DEBUG	Init aborted (running=false, enabled=true, finalUIStartup=false)
[task 2018-05-28T13:41:39.130Z] 13:41:39     INFO - PID 5559 | 1527514899123	Marionette	DEBUG	Received observer notification sessionstore-windows-restored
[task 2018-05-28T13:41:39.130Z] 13:41:39     INFO - PID 5559 | 1527514899123	Marionette	DEBUG	Waiting for delayed startup...
[task 2018-05-28T13:41:41.384Z] 13:41:41     INFO - PID 5559 | 1527514901378	Marionette	DEBUG	Waiting for startup tests...
[task 2018-05-28T13:41:41.386Z] 13:41:41     INFO - PID 5559 | 1527514901379	Marionette	DEBUG	Setting recommended pref toolkit.cosmeticAnimations.enabled to false
[task 2018-05-28T13:41:41.386Z] 13:41:41     INFO - PID 5559 | 1527514901379	Marionette	DEBUG	Setting recommended pref datareporting.policy.dataSubmissionPolicyAccepted to false
[task 2018-05-28T13:41:41.388Z] 13:41:41     INFO - PID 5559 | 1527514901379	Marionette	DEBUG	Setting recommended pref dom.disable_beforeunload to true
[task 2018-05-28T13:41:41.444Z] 13:41:41     INFO - PID 5559 | 1527514901433	Marionette	INFO	Listening on port 2828
[task 2018-05-28T13:41:41.446Z] 13:41:41     INFO - PID 5559 | 1527514901434	Marionette	DEBUG	Remote service is active
[task 2018-05-28T13:41:41.503Z] 13:41:41     INFO - PID 5559 | 1527514901487	geckodriver::marionette	DEBUG	Connected to Marionette on 127.0.0.1:2828
[task 2018-05-28T13:41:41.516Z] 13:41:41     INFO - PID 5559 | 1527514901505	Marionette	DEBUG	Accepted connection 0 from 127.0.0.1:54880
[task 2018-05-28T13:41:41.517Z] 13:41:41     INFO - PID 5559 | 1527514901508	Marionette	TRACE	0 -> [0,1,"WebDriver:NewSession",{"capabilities":{"desiredCapabilities":{}}}]
[task 2018-05-28T13:41:41.574Z] 13:41:41     INFO - PID 5559 | 1527514901560	Marionette	DEBUG	Register listener.js for window 2147483649
[task 2018-05-28T13:41:41.594Z] 13:41:41     INFO - PID 5559 | 1527514901588	Marionette	TRACE	0 <- [1,1,null,{"sessionId":"b5eb59bf-54e0-4926-8ca2-fed7bbecfcda","capabilities":{"browserName":"firefox","browserVersion":"62.0a ... 5,"moz:profile":"/tmp/rust_mozprofile.etfY0jPwoNaT","moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true}}]
[task 2018-05-28T13:41:41.595Z] 13:41:41     INFO - STDOUT: PASSED
[task 2018-05-28T13:41:41.599Z] 13:41:41     INFO - PID 5559 | 1527514901590	webdriver::server	DEBUG	<- 200 OK {"value": {"sessionId":"b5eb59bf-54e0-4926-8ca2-fed7bbecfcda","capabilities":{"acceptInsecureCerts":false,"browserName":"firefox","browserVersion":"62.0a1","moz:accessibilityChecks":false,"moz:headless":false,"moz:processID":8505,"moz:profile":"/tmp/rust_mozprofile.etfY0jPwoNaT","moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true,"pageLoadStrategy":"normal","platformName":"linux","platformVersion":"4.4.0-1014-aws","rotatable":false,"timeouts":{"implicit":0,"pageLoad":300000,"script":30000}}}}
[task 2018-05-28T13:41:41.599Z] 13:41:41     INFO - PID 5559 | 1527514901593	webdriver::server	DEBUG	-> DELETE /session/b5eb59bf-54e0-4926-8ca2-fed7bbecfcda
[task 2018-05-28T13:41:41.616Z] 13:41:41     INFO - PID 5559 | 1527514901607	Marionette	TRACE	0 -> [0,2,"Marionette:Quit",{"flags":["eForceQuit"]}]
[task 2018-05-28T13:41:41.617Z] 13:41:41     INFO - PID 5559 | 1527514901608	Marionette	INFO	Stopped listening on port 2828
[task 2018-05-28T13:41:41.679Z] 13:41:41     INFO - PID 5559 | 1527514901676	Marionette	TRACE	0 <- [1,2,null,{"cause":"shutdown"}]
[task 2018-05-28T13:41:41.736Z] 13:41:41     INFO - PID 5559 | 1527514901728	webdriver::server	DEBUG	Deleting session
[task 2018-05-28T13:41:41.740Z] 13:41:41     INFO - PID 5559 | 1527514901735	Marionette	TRACE	0 -> [0,3,"Marionette:Quit",{"flags":["eForceQuit"]}]
[task 2018-05-28T13:41:41.741Z] 13:41:41     INFO - PID 5559 | 1527514901735	Marionette	TRACE	0 <- [1,3,{"error":"invalid session id","message":"","stacktrace":"WebDriverError@chrome://marionette/content/error.js:178:5\nInva ... et@chrome://marionette/content/server.js:244:8\n_onJSONObjectReady/<@chrome://marionette/content/transport.js:500:9\n"},null]
[task 2018-05-28T13:41:41.759Z] 13:41:41     INFO - PID 5559 | 1527514901748	Marionette	DEBUG	Closed connection 0
[task 2018-05-28T13:41:41.795Z] 13:41:41     INFO - PID 5559 | JavaScript error: resource://gre/modules/JSONFile.jsm, line 159: Error: Data is not ready.
[task 2018-05-28T13:41:41.796Z] 13:41:41     INFO - PID 5559 | JavaScript error: resource://gre/modules/JSONFile.jsm, line 159: Error: Data is not ready.
[task 2018-05-28T13:41:41.796Z] 13:41:41     INFO - PID 5559 | JavaScript error: resource://gre/modules/JSONFile.jsm, line 159: Error: Data is not ready.
[task 2018-05-28T13:41:41.913Z] 13:41:41     INFO - PID 5559 | 1527514901905	Marionette	DEBUG	Received observer notification xpcom-will-shutdown
[task 2018-05-28T13:41:41.913Z] 13:41:41     INFO - PID 5559 | 1527514901906	Marionette	DEBUG	Resetting recommended pref toolkit.cosmeticAnimations.enabled
[task 2018-05-28T13:41:41.914Z] 13:41:41     INFO - PID 5559 | 1527514901907	Marionette	DEBUG	Resetting recommended pref datareporting.policy.dataSubmissionPolicyAccepted
[task 2018-05-28T13:41:41.914Z] 13:41:41     INFO - PID 5559 | 1527514901907	Marionette	DEBUG	Resetting recommended pref dom.disable_beforeunload
[task 2018-05-28T13:41:41.915Z] 13:41:41     INFO - PID 5559 | 1527514901907	Marionette	DEBUG	Remote service is inactive
[task 2018-05-28T13:41:41.932Z] 13:41:41     INFO - PID 5559 | JavaScript error: resource://gre/modules/osfile/osfile_async_front.jsm, line 408: Error: OS.File has been shut down. Rejecting post to DirectoryIterator_prototype_close
[task 2018-05-28T13:41:41.934Z] 13:41:41     INFO - PID 5559 | JavaScript error: resource://gre/modules/osfile/osfile_async_front.jsm, line 408: Error: OS.File has been shut down. Rejecting post to DirectoryIterator_prototype_close
[task 2018-05-28T13:41:41.937Z] 13:41:41     INFO - PID 5559 | JavaScript error: resource://gre/modules/ProfileAge.jsm, line 174: Error: Unable to fetch oldest profile entry: Error: OS.File has been shut down. Rejecting request to DirectoryIterator_prototype_next
[task 2018-05-28T13:41:41.938Z] 13:41:41     INFO - PID 5559 | JavaScript error: resource://gre/modules/ProfileAge.jsm, line 174: Error: Unable to fetch oldest profile entry: Error: OS.File has been shut down. Rejecting post to DirectoryIterator_prototype_next
[task 2018-05-28T13:41:42.242Z] 13:41:42     INFO - PID 5559 | 1527514902238	geckodriver::marionette	DEBUG	Browser process stopped: exit code: 0
[task 2018-05-28T13:41:42.246Z] 13:41:42     INFO - PID 5559 | 1527514902243	webdriver::server	DEBUG	<- 200 OK {"value": {}}
[task 2018-05-28T13:41:42.250Z] 13:41:42     INFO - STDOUT: =================================== FAILURES ===================================
[task 2018-05-28T13:41:42.251Z] 13:41:42     INFO - STDOUT: _________________________ test_valid[timeouts-value10] _________________________
[task 2018-05-28T13:41:42.252Z] 13:41:42     INFO - STDOUT: new_session = <function create_session at 0x7f056d6bca28>
[task 2018-05-28T13:41:42.255Z] 13:41:42     INFO - STDOUT: add_browser_capabilites = <function update_capabilities at 0x7f056d6bcd70>
[task 2018-05-28T13:41:42.256Z] 13:41:42     INFO - STDOUT: key = 'timeouts'
[task 2018-05-28T13:41:42.256Z] 13:41:42     INFO - STDOUT: value = {'implicit': 9007199254740991, 'pageLoad': 2.0, 'script': 0}
[task 2018-05-28T13:41:42.257Z] 13:41:42     INFO - STDOUT:     @pytest.mark.parametrize("key,value", flatten(product(*item) for item in valid_data))
[task 2018-05-28T13:41:42.257Z] 13:41:42     INFO - STDOUT:     def test_valid(new_session, add_browser_capabilites, key, value):
[task 2018-05-28T13:41:42.258Z] 13:41:42     INFO - STDOUT: >       resp = new_session({"capabilities": {"alwaysMatch": add_browser_capabilites({key: value})}})
[task 2018-05-28T13:41:42.258Z] 13:41:42     INFO - STDOUT: add_browser_capabilites = <function update_capabilities at 0x7f056d6bcd70>
[task 2018-05-28T13:41:42.259Z] 13:41:42     INFO - STDOUT: key        = 'timeouts'
[task 2018-05-28T13:41:42.259Z] 13:41:42     INFO - STDOUT: new_session = <function create_session at 0x7f056d6bca28>
[task 2018-05-28T13:41:42.260Z] 13:41:42     INFO - STDOUT: value      = {'implicit': 9007199254740991, 'pageLoad': 2.0, 'script': 0}
[task 2018-05-28T13:41:42.260Z] 13:41:42     INFO - STDOUT: tests/web-platform/tests/webdriver/tests/new_session/create_alwaysMatch.py
[task 2018-05-28T13:41:42.266Z] 13:41:42     INFO - STDOUT: :12: 
[task 2018-05-28T13:41:42.266Z] 13:41:42     INFO - STDOUT: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
[task 2018-05-28T13:41:42.266Z] 13:41:42     INFO - STDOUT: tests/web-platform/tests/webdriver/tests/support/fixtures.py
[task 2018-05-28T13:41:42.266Z] 13:41:42     INFO - STDOUT: :192: in create_session
[task 2018-05-28T13:41:42.266Z] 13:41:42     INFO - STDOUT:     value = _session.send_command("POST", "session", body=body)
[task 2018-05-28T13:41:42.266Z] 13:41:42     INFO - STDOUT: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
[task 2018-05-28T13:41:42.267Z] 13:41:42     INFO - STDOUT: self = <Session (disconnected)>, method = 'POST', url = 'session'
[task 2018-05-28T13:41:42.267Z] 13:41:42     INFO - STDOUT: body = {'capabilities': {'alwaysMatch': {'moz:firefoxOptions': {'binary': '/builds/worker/workspace/build/application/firefox...--n8j6ds53lwwkrqhv28a.web-platform.test'}}, 'timeouts': {'implicit': 9007199254740991, 'pageLoad': 2.0, 'script': 0}}}}
[task 2018-05-28T13:41:42.267Z] 13:41:42     INFO - STDOUT:     def send_command(self, method, url, body=None):
[task 2018-05-28T13:41:42.267Z] 13:41:42     INFO - STDOUT:         """
[task 2018-05-28T13:41:42.267Z] 13:41:42     INFO - STDOUT:             Send a command to the remote end and validate its success.
[task 2018-05-28T13:41:42.268Z] 13:41:42     INFO - STDOUT:     
[task 2018-05-28T13:41:42.268Z] 13:41:42     INFO - STDOUT:             :param method: HTTP method to use in request.
[task 2018-05-28T13:41:42.269Z] 13:41:42     INFO - STDOUT:             :param uri: "Command part" of the HTTP request URL,
[task 2018-05-28T13:41:42.269Z] 13:41:42     INFO - STDOUT:                 e.g. `window/rect`.
[task 2018-05-28T13:41:42.269Z] 13:41:42     INFO - STDOUT:             :param body: Optional body of the HTTP request.
[task 2018-05-28T13:41:42.270Z] 13:41:42     INFO - STDOUT:     
[task 2018-05-28T13:41:42.270Z] 13:41:42     INFO - STDOUT:             :return: `None` if the HTTP response body was empty, otherwise
[task 2018-05-28T13:41:42.271Z] 13:41:42     INFO - STDOUT:                 the `value` field returned after parsing the response
[task 2018-05-28T13:41:42.271Z] 13:41:42     INFO - STDOUT:                 body as JSON.
[task 2018-05-28T13:41:42.273Z] 13:41:42     INFO - STDOUT:     
[task 2018-05-28T13:41:42.273Z] 13:41:42     INFO - STDOUT:             :raises ValueError: If the response body does not contain a
[task 2018-05-28T13:41:42.273Z] 13:41:42     INFO - STDOUT:                 `value` key.
[task 2018-05-28T13:41:42.274Z] 13:41:42     INFO - STDOUT:             :raises error.WebDriverException: If the remote end returns
[task 2018-05-28T13:41:42.274Z] 13:41:42     INFO - STDOUT:                 an error.
[task 2018-05-28T13:41:42.274Z] 13:41:42     INFO - STDOUT:             """
[task 2018-05-28T13:41:42.275Z] 13:41:42     INFO - STDOUT:         response = self.transport.send(
[task 2018-05-28T13:41:42.276Z] 13:41:42     INFO - STDOUT:             method, url, body,
[task 2018-05-28T13:41:42.276Z] 13:41:42     INFO - STDOUT:             encoder=protocol.Encoder, decoder=protocol.Decoder,
[task 2018-05-28T13:41:42.277Z] 13:41:42     INFO - STDOUT:             session=self)
[task 2018-05-28T13:41:42.277Z] 13:41:42     INFO - STDOUT:     
[task 2018-05-28T13:41:42.277Z] 13:41:42     INFO - STDOUT:         if response.status != 200:
[task 2018-05-28T13:41:42.278Z] 13:41:42     INFO - STDOUT:             err = error.from_response(response)
[task 2018-05-28T13:41:42.278Z] 13:41:42     INFO - STDOUT:     
[task 2018-05-28T13:41:42.279Z] 13:41:42     INFO - STDOUT:             if isinstance(err, error.SessionNotCreatedException):
[task 2018-05-28T13:41:42.279Z] 13:41:42     INFO - STDOUT:                 # The driver could have already been deleted the session.
[task 2018-05-28T13:41:42.280Z] 13:41:42     INFO - STDOUT:                 self.session_id = None
[task 2018-05-28T13:41:42.280Z] 13:41:42     INFO - STDOUT:     
[task 2018-05-28T13:41:42.282Z] 13:41:42     INFO - STDOUT: >           raise err
[task 2018-05-28T13:41:42.282Z] 13:41:42     INFO - STDOUT: E           InvalidArgumentException: invalid argument (400): pageLoad timeouts value is not an integer: 2.0
[task 2018-05-28T13:41:42.283Z] 13:41:42     INFO - STDOUT: body       = {'capabilities': {'alwaysMatch': {'moz:firefoxOptions': {'binary': '/builds/worker/workspace/build/application/firefox...--n8j6ds53lwwkrqhv28a.web-platform.test'}}, 'timeouts': {'implicit': 9007199254740991, 'pageLoad': 2.0, 'script': 0}}}}
[task 2018-05-28T13:41:42.283Z] 13:41:42     INFO - STDOUT: err        = <InvalidArgumentException http_status=400>
[task 2018-05-28T13:41:42.284Z] 13:41:42     INFO - STDOUT: method     = 'POST'
[task 2018-05-28T13:41:42.285Z] 13:41:42     INFO - STDOUT: response   = <Response status=400 error=<InvalidArgumentException http_status=400>>
[task 2018-05-28T13:41:42.285Z] 13:41:42     INFO - STDOUT: self       = <Session (disconnected)>
[task 2018-05-28T13:41:42.286Z] 13:41:42     INFO - STDOUT: url        = 'session'
[task 2018-05-28T13:41:42.286Z] 13:41:42     INFO - STDOUT: tests/web-platform/tests/tools/webdriver/webdriver/client.py
[task 2018-05-28T13:41:42.286Z] 13:41:42     INFO - STDOUT: :445: InvalidArgumentException
[task 2018-05-28T13:41:42.287Z] 13:41:42     INFO - STDOUT: =============================== warnings summary ===============================
[task 2018-05-28T13:41:42.287Z] 13:41:42     INFO - STDOUT: None
[task 2018-05-28T13:41:42.288Z] 13:41:42     INFO - STDOUT:   Module already imported so cannot be rewritten: mozlog
[task 2018-05-28T13:41:42.289Z] 13:41:42     INFO - STDOUT: -- Docs: http://doc.pytest.org/en/latest/warnings.html
[task 2018-05-28T13:41:42.289Z] 13:41:42     INFO - STDOUT: ============== 1 failed, 22 passed, 1 warnings in 110.51 seconds ===============
[task 2018-05-28T13:41:42.299Z] 13:41:42     INFO - TEST-UNEXPECTED-OK | /webdriver/tests/new_session/create_alwaysMatch.py | expected TIMEOUT 

Kats, could you please take a look at this? It only fails on Linux x64 QuantumRender.

Comment 42

[Kartikaya Gupta (email:[e-mail])]

Thanks. I had seen that in some try pushes but didn't realize it was a perma condition. The good news is that this is an UNEXPECTED-OK, so I can just remove the timeout expectation from the .ini files and it should be good. I'll land that patch shortly.

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66b6a79c3bb0
Follow-up to remove timeout expectation from some QR tests, because it's not timing out any more. r=me

Comment 44

[Kartikaya Gupta (email:[e-mail])]

Also for the record: from the try pushes, the UNEXPECTED-OK was a result of servo/webrender#2767.

Comment 45

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/66b6a79c3bb0

Comment 46

[Intermittent Failures Robot]

5 failures in 655 pushes (0.008 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 5

Platform breakdown:
* linux64-qr: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1463416&startday=2018-05-28&endday=2018-06-03&tree=trunk