1463480 - "Add new jobs" failing with "UnboundLocalError: local variable 'task' referenced before assignment"

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Jonathan Kew [:jfkthame]]

See for example https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0316f57217953f33a93a93d22fc64701942c2ec&group_state=expanded&selectedJob=179670921

Comment 1

[Ed Morley [:emorley]]

From the raw log:

[task 2018-05-22T16:01:59.335Z] executing ['bash', '-cx', 'cd /builds/worker/checkouts/gecko && ln -s /builds/worker/artifacts artifacts && ./mach --log-no-times taskgraph action-callback\n']
[task 2018-05-22T16:01:59.337Z] + cd /builds/worker/checkouts/gecko
[task 2018-05-22T16:01:59.337Z] + ln -s /builds/worker/artifacts artifacts
[task 2018-05-22T16:01:59.338Z] + ./mach --log-no-times taskgraph action-callback
[task 2018-05-22T16:01:59.648Z] loading config from `taskcluster/ci/config.yml`
[task 2018-05-22T16:01:59.701Z] Traceback (most recent call last):
[task 2018-05-22T16:01:59.701Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 250, in action_callback
[task 2018-05-22T16:01:59.701Z]     test=False)
[task 2018-05-22T16:01:59.701Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/registry.py", line 289, in trigger_action_callback
[task 2018-05-22T16:01:59.702Z]     cb(Parameters(**parameters), graph_config, input, task_group_id, task_id, task)
[task 2018-05-22T16:01:59.702Z] UnboundLocalError: local variable 'task' referenced before assignment

Changelog for that file:
https://hg.mozilla.org/mozilla-central/filelog/51f2535c797495f1f4e864072c2449b7c28669de/taskcluster/taskgraph/actions/registry.py

Also recently this landed on the Treeherder side (and is in production already):
https://github.com/mozilla/treeherder/pull/3502

Dustin, I don't suppose you have any ideas? :-)

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1463480 - always set task, even for taskgraph-level actions;

Review commit: https://reviewboard.mozilla.org/r/245808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245808/

Comment 3

[Tom Prince [:tomprince]]

Comment on attachment 8979670 [details]
Bug 1463480 - always set task, even for taskgraph-level actions;

https://reviewboard.mozilla.org/r/245808/#review251918

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32f3c058a394
always set task, even for taskgraph-level actions; r=tomprince

Comment 5

[Ed Morley [:emorley]]

Many thanks for the fix! :-)

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/32f3c058a394