Closed Bug 1463481 Opened Last year Closed Last year

Update Debugger Frontend v58

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: jlast, Assigned: jlast)

Details

Attachments

(1 file, 3 obsolete files)

Attached patch 58-2.patch (obsolete) — Splinter Review
Attachment #8979896 - Flags: review?(dwalsh)
Assignee: nobody → jlaster
Priority: -- → P3
Comment on attachment 8979896 [details] [diff] [review]
58-2.patch

Review of attachment 8979896 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/shared/components/reps/reps.js
@@ +6163,5 @@
>  const { connect } = __webpack_require__(3592);
>  const { bindActionCreators } = __webpack_require__(3593);
>  
> +const { appinfo } = _devtoolsServices2.default;
> +const isMacOS = appinfo.OS === "Darwin";

we seems to miss the code that goes with this change: https://github.com/devtools-html/debugger.html/blob/e1a829e87284193428887349d8a981dfa2d73533/packages/devtools-reps/src/object-inspector/component.js#L388-L391 , or is it already landed ?
I think he's speaking with regard to this PR:

https://github.com/devtools-html/debugger.html/pull/6311/files

I don't think I see the change to packages/devtools-reps/src/object-inspector/tests/component/events.js
Nice catch, that commit was in fact missing

https://searchfox.org/mozilla-central/source/devtools/client/shared/components/reps/reps.js#6447

I believe the story was that we landed it early, then excluded it from 55 because of the modules thing. Landed the services fix. and never re-landed this commit.
Attached patch 58-3.patch (obsolete) — Splinter Review
Attachment #8979896 - Attachment is obsolete: true
Attachment #8979896 - Flags: review?(dwalsh)
Attachment #8979976 - Flags: review?(dwalsh)
Comment on attachment 8979976 [details] [diff] [review]
58-3.patch

Review of attachment 8979976 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me for the reps.js file :)
Comment on attachment 8979976 [details] [diff] [review]
58-3.patch

Review of attachment 8979976 [details] [diff] [review]:
-----------------------------------------------------------------

I'm trying to import on top of 57 and I'm seeing:

~/Projects/mozilla-inbound $ hg checkout -r 419365
57 files updated, 0 files merged, 5 files removed, 0 files unresolved
~/Projects/mozilla-inbound $ hg import https://bug1463481.bmoattachments.org/attachment.cgi?id=8979976
applying https://bug1463481.bmoattachments.org/attachment.cgi?id=8979976
patching file devtools/client/shared/components/reps/reps.js
Hunk #3 FAILED at 4410
1 out of 5 hunks FAILED -- saving rejects to file devtools/client/shared/components/reps/reps.js.rej
abort: patch failed to apply

I'm also seeing red "B"'s on Treeherder.
Attached patch 58-4.patch (obsolete) — Splinter Review
Attachment #8979976 - Attachment is obsolete: true
Attachment #8979976 - Flags: review?(dwalsh)
Attachment #8980114 - Flags: review?(dwalsh)
david, try applying that on top of a clean mozilla-central.
Attachment #8980114 - Flags: review?(dwalsh) → review+
Backed out for devtools failures on several files.

Push with failures: hhttps://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=devtools&fromchange=432b51c73e203e36f2a80fa687018d15a0f90a11&tochange=c106211c6ed5e6a580da659f0a629e281b98bcf7&selectedJob=180025682

Failure log: 
https://treeherder.mozilla.org/logviewer.html#?job_id=180025682&repo=mozilla-inbound&lineNumber=9459
https://treeherder.mozilla.org/logviewer.html#?job_id=180049111&repo=mozilla-inbound&lineNumber=3746

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/c106211c6ed5e6a580da659f0a629e281b98bcf7
Flags: needinfo?(jlaster)
thanks. will look into it
Flags: needinfo?(jlaster)
Attached patch 58-6.patchSplinter Review
Attachment #8980114 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/f38805d4a389
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.