1463481 - Update Debugger Frontend v58

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

https://github.com/devtools-html/debugger.html/compare/release-57...release-58

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=90b4fab9fbe27c16b001fc3740ec403c296ea82b

Comment 2

[Jason Laster [:jlast]]

Attachment: 58-2.patch

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=644cd20d3159abc823f013b092f73e9910a399b2

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8979896 [details] [diff] [review]
58-2.patch

Review of attachment 8979896 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/shared/components/reps/reps.js
@@ +6163,5 @@
>  const { connect } = __webpack_require__(3592);
>  const { bindActionCreators } = __webpack_require__(3593);
>  
> +const { appinfo } = _devtoolsServices2.default;
> +const isMacOS = appinfo.OS === "Darwin";

we seems to miss the code that goes with this change: https://github.com/devtools-html/debugger.html/blob/e1a829e87284193428887349d8a981dfa2d73533/packages/devtools-reps/src/object-inspector/component.js#L388-L391 , or is it already landed ?

Comment 5

[Jason Laster [:jlast]]

Not sure what you're referring to. Here's the 57 comparison 
https://github.com/devtools-html/debugger.html/compare/release-56...release-57
https://bugzilla.mozilla.org/show_bug.cgi?id=1463415

Comment 6

[David Walsh :davidwalsh]

I think he's speaking with regard to this PR:

https://github.com/devtools-html/debugger.html/pull/6311/files

I don't think I see the change to packages/devtools-reps/src/object-inspector/tests/component/events.js

Comment 7

[Jason Laster [:jlast]]

Nice catch, that commit was in fact missing

https://searchfox.org/mozilla-central/source/devtools/client/shared/components/reps/reps.js#6447

I believe the story was that we landed it early, then excluded it from 55 because of the modules thing. Landed the services fix. and never re-landed this commit.

Comment 8

[Jason Laster [:jlast]]

Attachment: 58-3.patch

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8979976 [details] [diff] [review]
58-3.patch

Review of attachment 8979976 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me for the reps.js file :)

Comment 10

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc770c642f55126a6d01047182efec058d9ed95d

Comment 11

[David Walsh :davidwalsh]

Comment on attachment 8979976 [details] [diff] [review]
58-3.patch

Review of attachment 8979976 [details] [diff] [review]:
-----------------------------------------------------------------

I'm trying to import on top of 57 and I'm seeing:

~/Projects/mozilla-inbound $ hg checkout -r 419365
57 files updated, 0 files merged, 5 files removed, 0 files unresolved
~/Projects/mozilla-inbound $ hg import https://bug1463481.bmoattachments.org/attachment.cgi?id=8979976
applying https://bug1463481.bmoattachments.org/attachment.cgi?id=8979976
patching file devtools/client/shared/components/reps/reps.js
Hunk #3 FAILED at 4410
1 out of 5 hunks FAILED -- saving rejects to file devtools/client/shared/components/reps/reps.js.rej
abort: patch failed to apply

I'm also seeing red "B"'s on Treeherder.

Comment 12

[Jason Laster [:jlast]]

Attachment: 58-4.patch

Comment 13

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=71168e52c56f39781471e81dd86e407ac23e0709

Comment 14

[Jason Laster [:jlast]]

david, try applying that on top of a clean mozilla-central.

Comment 15

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=997f28c2e0033a2b512a7b2b318d8e60c7794986

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/432b51c73e20
Update Debugger Frontend v58. r=dwalsh

Comment 17

[Cosmin Sabou [:CosminS]]

Backed out for devtools failures on several files.

Push with failures: hhttps://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=devtools&fromchange=432b51c73e203e36f2a80fa687018d15a0f90a11&tochange=c106211c6ed5e6a580da659f0a629e281b98bcf7&selectedJob=180025682

Failure log: 
https://treeherder.mozilla.org/logviewer.html#?job_id=180025682&repo=mozilla-inbound&lineNumber=9459
https://treeherder.mozilla.org/logviewer.html#?job_id=180049111&repo=mozilla-inbound&lineNumber=3746

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/c106211c6ed5e6a580da659f0a629e281b98bcf7

Comment 18

[Jason Laster [:jlast]]

thanks. will look into it

Comment 19

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e88d35d202071348f2c99144743c0a2abcb7795

Comment 20

[Jason Laster [:jlast]]

Attachment: 58-6.patch

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f38805d4a389
Update Debugger Frontend v58. r=dwalsh

Comment 22

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f38805d4a389