Closed Bug 1463525 Opened 2 years ago Closed 2 years ago

Implement frontend for console.countReset()

Categories

(DevTools :: Console, enhancement)

Product:
DevTools
Component:
Console
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1463525 - Add frontend to countReset;
59 bytes, text/x-review-board-request
nchevobbe
: review+
Details 
+++ This bug was initially created as a clone of Bug #1459279 +++

Spinning this out into another bug to make landing the frontend for console.countReset easier
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8979717 [details]
Bug 1463525 - Add frontend to countReset;

https://reviewboard.mozilla.org/r/245842/#review252028
Attachment #8979717 - Flags: review?(nchevobbe) → review+
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)
> The patch is causing a failure
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=b0a5119fa698e67a8db29002aadc7596481f60be&selectedJob=1
> 79767893

I think that was because the platform patch hadn't stuck on m-c. Should be working now.
Are there any plans on making a call to `countReset()` with a label that doesn't have a counter yield in a warning, as is suggested by the spec, and done wiht `timeLog` and `timeEnd`?
(In reply to Dominic Farolino [:domfarolino] from comment #7)
> Are there any plans on making a call to `countReset()` with a label that
> doesn't have a counter yield in a warning, as is suggested by the spec, and
> done wiht `timeLog` and `timeEnd`?

Yes, there will be a "counter <counterName> doesn't exist" warning message in these cases
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3f6bb6829a5
Add frontend to countReset;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/f3f6bb6829a5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
Documentation added for the console.countReset method per Bug #1459279 - https://bugzilla.mozilla.org/show_bug.cgi?id=1459279#c24
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.