1463525 - Implement frontend for console.countReset()

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Brian Grinstead [:bgrins]]

+++ This bug was initially created as a clone of Bug #1459279 +++

Spinning this out into another bug to make landing the frontend for console.countReset easier

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1463525 - Add frontend to countReset;

Review commit: https://reviewboard.mozilla.org/r/245842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245842/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8979717 [details]
Bug 1463525 - Add frontend to countReset;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245842/diff/1-2/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8979717 [details]
Bug 1463525 - Add frontend to countReset;

https://reviewboard.mozilla.org/r/245842/#review252028

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

The patch is causing a failure https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0a5119fa698e67a8db29002aadc7596481f60be&selectedJob=179767893

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)
> The patch is causing a failure
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=b0a5119fa698e67a8db29002aadc7596481f60be&selectedJob=1
> 79767893

I think that was because the platform patch hadn't stuck on m-c. Should be working now.

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8979717 [details]
Bug 1463525 - Add frontend to countReset;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245842/diff/2-3/

Comment 7

[Dominic Farolino [:domfarolino]]

Are there any plans on making a call to `countReset()` with a label that doesn't have a counter yield in a warning, as is suggested by the spec, and done wiht `timeLog` and `timeEnd`?

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Dominic Farolino [:domfarolino] from comment #7)
> Are there any plans on making a call to `countReset()` with a label that
> doesn't have a counter yield in a warning, as is suggested by the spec, and
> done wiht `timeLog` and `timeEnd`?

Yes, there will be a "counter <counterName> doesn't exist" warning message in these cases

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8979717 [details]
Bug 1463525 - Add frontend to countReset;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245842/diff/3-4/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3f6bb6829a5
Add frontend to countReset;r=nchevobbe

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f3f6bb6829a5

Comment 12

[Irene Smith]

Documentation added for the console.countReset method per Bug #1459279 - https://bugzilla.mozilla.org/show_bug.cgi?id=1459279#c24