Closed
Bug 1463621
Opened 6 years ago
Closed 6 years ago
Remove old animation inspector
Categories
(DevTools :: Inspector: Animations, enhancement, P2)
DevTools
Inspector: Animations
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: daisuke, Assigned: daisuke)
References
(Depends on 1 open bug)
Details
Attachments
(4 files)
After we release new animation inspector, should remove old animation inspector related codes. We should check following files at least. * client/inspector/animation-old * client/inspector/inspector.js * client/preferences/devtools-client.js * server/actors/animation.js (e.g. bug 1454392 comment 40) * shared/fronts/animation.js * shared/specs/animation.js
Updated•6 years ago
|
Severity: normal → enhancement
Priority: -- → P2
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Comment 1•6 years ago
|
||
Also, should remove player.animationIterationStartLabel variable in animationinspector.properties[1]. [1] https://searchfox.org/mozilla-central/source/devtools/client/locales/en-US/animationinspector.properties#76
Assignee | ||
Comment 2•6 years ago
|
||
And, telemetry code which is reflecting new animation inspector. [1] https://searchfox.org/mozilla-central/source/devtools/client/shared/telemetry.js#601
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dakatsuka
Assignee | ||
Comment 3•6 years ago
|
||
In this patch, remove main codes of old animation inspector such the inspector/animation-old directory. Additionally, remove the codes that had been referring the old codes. Also, remove a CSS variable which no longer reffered in inspector from devtools/client/themes/breadcrumbs.css, because this caused a test failure occur from browser/base/content/test/static/browser_parsable_css.js. In this patch, remove animationinspector.css as well. The reason why the error was not occurred so far is that it had been interpreted that animationinspector.css refer to the variable.
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D5498
Assignee | ||
Comment 5•6 years ago
|
||
Depends on D5499
Assignee | ||
Comment 6•6 years ago
|
||
Depends on D5500
Assignee | ||
Comment 7•6 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&author=dakatsuka@mozilla.com&fromchange=c47a95a285ad6a3ff9e77a83a2f07545c68f2c65
Comment 8•6 years ago
|
||
Comment on attachment 9007965 [details] Bug 1463621 - Part 2: Remove devtools.new-animationinspector.enabled preference. r=pbro Patrick Brosset <:pbro> has approved the revision.
Attachment #9007965 -
Flags: review+
Comment 9•6 years ago
|
||
Comment on attachment 9007966 [details] Bug 1463621 - Part 3: Rename application name. r=pbro Patrick Brosset <:pbro> has approved the revision.
Attachment #9007966 -
Flags: review+
Comment 10•6 years ago
|
||
Comment on attachment 9007968 [details] Bug 1463621 - Part 4: Remove no longer used variables in locale. r=pbro Patrick Brosset <:pbro> has approved the revision.
Attachment #9007968 -
Flags: review+
Comment 11•6 years ago
|
||
Comment on attachment 9007964 [details] Bug 1463621 - Part 1: Remove main codes of old animation inspector. r=pbro Patrick Brosset <:pbro> has approved the revision.
Attachment #9007964 -
Flags: review+
Comment 12•6 years ago
|
||
Comment on attachment 9007964 [details] Bug 1463621 - Part 1: Remove main codes of old animation inspector. r=pbro :Gijs (he/him) has approved the revision.
Attachment #9007964 -
Flags: review+
Comment 13•6 years ago
|
||
Pushed by dakatsuka@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f05a37297647 Part 1: Remove main codes of old animation inspector. r=pbro,r=Gijs https://hg.mozilla.org/integration/mozilla-inbound/rev/46032e616f5d Part 2: Remove devtools.new-animationinspector.enabled preference. r=pbro https://hg.mozilla.org/integration/mozilla-inbound/rev/afcb44c66c5f Part 3: Rename application name. r=pbro https://hg.mozilla.org/integration/mozilla-inbound/rev/5d653605ce14 Part 4: Remove no longer used variables in locale. r=pbro
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f05a37297647 https://hg.mozilla.org/mozilla-central/rev/46032e616f5d https://hg.mozilla.org/mozilla-central/rev/afcb44c66c5f https://hg.mozilla.org/mozilla-central/rev/5d653605ce14
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment 15•6 years ago
|
||
Note that there is two leftovers: https://searchfox.org/mozilla-central/search?q=animation-old&case=false®exp=false&path= This module seems to be no longer used: https://searchfox.org/mozilla-central/source/devtools/client/inspector/shared/dom-node-preview.js https://searchfox.org/mozilla-central/search?q=dom-node-preview&case=false®exp=false&path=
Assignee | ||
Comment 16•6 years ago
|
||
Indeed! I had forgot to remove this. Thank you very much, Alexandre!
You need to log in
before you can comment on or make changes to this bug.
Description
•