Closed Bug 1463621 Opened Last year Closed Last year

Remove old animation inspector

Categories

(DevTools :: Inspector: Animations, enhancement, P2)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

(Depends on 1 open bug)

Details

Attachments

(4 files)

After we release new animation inspector, should remove old animation inspector related codes. We should check following files at least.

* client/inspector/animation-old
* client/inspector/inspector.js
* client/preferences/devtools-client.js
* server/actors/animation.js (e.g. bug 1454392 comment 40)
* shared/fronts/animation.js
* shared/specs/animation.js
Severity: normal → enhancement
Priority: -- → P2
Product: Firefox → DevTools
Also, should remove player.animationIterationStartLabel variable in animationinspector.properties[1].

[1] https://searchfox.org/mozilla-central/source/devtools/client/locales/en-US/animationinspector.properties#76
And, telemetry code which is reflecting new animation inspector.

[1] https://searchfox.org/mozilla-central/source/devtools/client/shared/telemetry.js#601
Assignee: nobody → dakatsuka
In this patch, remove main codes of old animation inspector such the
inspector/animation-old directory. Additionally, remove the codes that had been
referring the old codes.

Also, remove a CSS variable which no longer reffered in inspector from
devtools/client/themes/breadcrumbs.css, because this caused a test failure occur
from browser/base/content/test/static/browser_parsable_css.js. In this patch,
remove animationinspector.css as well. The reason why the error was not occurred
so far is that it had been interpreted that animationinspector.css refer to the
variable.
Comment on attachment 9007965 [details]
Bug 1463621 - Part 2: Remove devtools.new-animationinspector.enabled preference. r=pbro

Patrick Brosset <:pbro> has approved the revision.
Attachment #9007965 - Flags: review+
Comment on attachment 9007966 [details]
Bug 1463621 - Part 3: Rename application name. r=pbro

Patrick Brosset <:pbro> has approved the revision.
Attachment #9007966 - Flags: review+
Comment on attachment 9007968 [details]
Bug 1463621 - Part 4: Remove no longer used variables in locale. r=pbro

Patrick Brosset <:pbro> has approved the revision.
Attachment #9007968 - Flags: review+
Comment on attachment 9007964 [details]
Bug 1463621 - Part 1: Remove main codes of old animation inspector. r=pbro

Patrick Brosset <:pbro> has approved the revision.
Attachment #9007964 - Flags: review+
Comment on attachment 9007964 [details]
Bug 1463621 - Part 1: Remove main codes of old animation inspector. r=pbro

:Gijs (he/him) has approved the revision.
Attachment #9007964 - Flags: review+
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f05a37297647
Part 1: Remove main codes of old animation inspector. r=pbro,r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/46032e616f5d
Part 2: Remove devtools.new-animationinspector.enabled preference. r=pbro
https://hg.mozilla.org/integration/mozilla-inbound/rev/afcb44c66c5f
Part 3: Rename application name. r=pbro
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d653605ce14
Part 4: Remove no longer used variables in locale. r=pbro
See Also: → 1490583
Indeed! I had forgot to remove this.
Thank you very much, Alexandre!
See Also: → 1492035
You need to log in before you can comment on or make changes to this bug.