1463635 - Update test_temporary to use WebExtensions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Kris Maglione [:kmag]]

It currently uses legacy extensions almost exclusively. Aside from the fact that those are no longer supported, they also can't be tested unpacked in release builds, which means we're missing coverage every time we merge to beta.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests.

Review commit: https://reviewboard.mozilla.org/r/245978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245978/

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

Review commit: https://reviewboard.mozilla.org/r/245980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245980/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8979817 [details]
Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests.

https://reviewboard.mozilla.org/r/245978/#review252014

::: toolkit/mozapps/extensions/test/xpcshell/test_temporary.js:306
(Diff revision 1)
>        // existing add-on is back
> -      Assert.notEqual(addon, null);
> -      Assert.equal(addon.version, "2.0");
> -      Assert.equal(addon.name, "Test Bootstrap 1");
> -      Assert.ok(addon.isCompatible);
> -      Assert.ok(!addon.appDisabled);
> +      checkAddon(ID, addon, {
> +        version: "2.0",
> +        name: "Test Bootstrap 1",
> +        isCompatible: true,
> +        appDisabled: !true,

Macros. Fixed.

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8979817 [details]
Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245978/diff/1-2/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8979818 [details]
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245980/diff/1-2/

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 8979817 [details]
Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests.

https://reviewboard.mozilla.org/r/245978/#review256770

Nice, thanks

Comment 7

[Andrew Swan [:aswan]]

Comment on attachment 8979818 [details]
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

https://reviewboard.mozilla.org/r/245980/#review256780

::: toolkit/mozapps/extensions/test/xpcshell/head_addons.js:428
(Diff revision 2)
>          // Close enough, for now.
>          this.onBootstrapMethod("uninstall",
>                                 Object.assign({}, params, {version: params.oldVersion}),
> -                               reason);
> +                               reason, method);
>          this.onBootstrapMethod("install", params, reason);

This is getting convoluted, why wouldn't this be sufficient:
```
checkMatches("update", "install", ...);
this.installed.set(id, ...);
```

Comment 8

[Kris Maglione [:kmag]]

Comment on attachment 8979818 [details]
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

https://reviewboard.mozilla.org/r/245980/#review256780

> This is getting convoluted, why wouldn't this be sufficient:
> ```
> checkMatches("update", "install", ...);
> this.installed.set(id, ...);
> ```

It probably would be, but it was late.

Comment 9

[Kris Maglione [:kmag]]

Comment on attachment 8979817 [details]
Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245978/diff/2-3/

Comment 10

[Kris Maglione [:kmag]]

Comment on attachment 8979818 [details]
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245980/diff/2-3/

Comment 11

[Andrew Swan [:aswan]]

Comment on attachment 8979818 [details]
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

https://reviewboard.mozilla.org/r/245980/#review257590

::: testing/xpcshell/head.js:797
(Diff revision 3)
>  }
>  
>  function do_report_result(passed, text, stack, todo) {
>    // Match names like head.js, head_foo.js, and foo_head.js, but not
>    // test_headache.js
> -  while (/(\/head(_.+)?|head)\.js$/.test(stack.filename) && stack.caller) {
> +  while (0 && /(\/head(_.+)?|head)\.js$/.test(stack.filename) && stack.caller) {

remove this before landing of course

Comment 12

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfbc714407cff60e009340206ead34176d5d41a2
Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/e166741fe81f169a689a1a94f3d42002baa290e9
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions. r=aswan

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cfbc714407cf
https://hg.mozilla.org/mozilla-central/rev/e166741fe81f