Closed Bug 1463635 Opened Last year Closed Last year

Update test_temporary to use WebExtensions

Categories

(Toolkit :: Add-ons Manager, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(2 files)

It currently uses legacy extensions almost exclusively. Aside from the fact that those are no longer supported, they also can't be tested unpacked in release builds, which means we're missing coverage every time we merge to beta.
Flags: qe-verify-
Comment on attachment 8979817 [details]
Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests.

https://reviewboard.mozilla.org/r/245978/#review252014

::: toolkit/mozapps/extensions/test/xpcshell/test_temporary.js:306
(Diff revision 1)
>        // existing add-on is back
> -      Assert.notEqual(addon, null);
> -      Assert.equal(addon.version, "2.0");
> -      Assert.equal(addon.name, "Test Bootstrap 1");
> -      Assert.ok(addon.isCompatible);
> -      Assert.ok(!addon.appDisabled);
> +      checkAddon(ID, addon, {
> +        version: "2.0",
> +        name: "Test Bootstrap 1",
> +        isCompatible: true,
> +        appDisabled: !true,

Macros. Fixed.
Priority: -- → P3
Comment on attachment 8979817 [details]
Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests.

https://reviewboard.mozilla.org/r/245978/#review256770

Nice, thanks
Attachment #8979817 - Flags: review?(aswan) → review+
Comment on attachment 8979818 [details]
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

https://reviewboard.mozilla.org/r/245980/#review256780

::: toolkit/mozapps/extensions/test/xpcshell/head_addons.js:428
(Diff revision 2)
>          // Close enough, for now.
>          this.onBootstrapMethod("uninstall",
>                                 Object.assign({}, params, {version: params.oldVersion}),
> -                               reason);
> +                               reason, method);
>          this.onBootstrapMethod("install", params, reason);

This is getting convoluted, why wouldn't this be sufficient:
```
checkMatches("update", "install", ...);
this.installed.set(id, ...);
```
Comment on attachment 8979818 [details]
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

https://reviewboard.mozilla.org/r/245980/#review256780

> This is getting convoluted, why wouldn't this be sufficient:
> ```
> checkMatches("update", "install", ...);
> this.installed.set(id, ...);
> ```

It probably would be, but it was late.
Comment on attachment 8979818 [details]
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions.

https://reviewboard.mozilla.org/r/245980/#review257590

::: testing/xpcshell/head.js:797
(Diff revision 3)
>  }
>  
>  function do_report_result(passed, text, stack, todo) {
>    // Match names like head.js, head_foo.js, and foo_head.js, but not
>    // test_headache.js
> -  while (/(\/head(_.+)?|head)\.js$/.test(stack.filename) && stack.caller) {
> +  while (0 && /(\/head(_.+)?|head)\.js$/.test(stack.filename) && stack.caller) {

remove this before landing of course
Attachment #8979818 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfbc714407cff60e009340206ead34176d5d41a2
Bug 1463635: Part 1 - Use slightly less dodgy, WebExtension-compatible bootstrap monitor for temporary add-on tests. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/e166741fe81f169a689a1a94f3d42002baa290e9
Bug 1463635: Part 2 - Update test_temporary to use mostly WebExtensions. r=aswan
https://hg.mozilla.org/mozilla-central/rev/cfbc714407cf
https://hg.mozilla.org/mozilla-central/rev/e166741fe81f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.