1463652 - Lazy load the sourceMapURLService from the rule editor

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P3)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1463652 - Lazy load the sourceMapURLService from the rule editor.

Review commit: https://reviewboard.mozilla.org/r/245998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245998/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

baseline https://treeherder.mozilla.org/#/jobs?repo=try&revision=857fbf80f2d499b7e0dafd64f16651e76b0aeef1
talos https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=b5bd7135a69f6352e1a8753aa04816e53fe9cf3d

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

We weren't lazily loading sourceMapURLService from the toolbox before because we directly called this.toolbox.sourceMapURLService in https://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/views/rule-editor.js#59, and you can see in toolbox.js that get sourceMapURLService is lazily loaded. 

This changes is to make sure we only load sourceMapURLService when we actually needed it in the rule-editor.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8979830 [details]
Bug 1463652 - Lazy load the sourceMapURLService from the rule editor.

https://reviewboard.mozilla.org/r/245998/#review252042

::: devtools/client/inspector/rules/views/rule-editor.js:105
(Diff revision 1)
> +    }
> +  },
> +
> +  get sourceMapURLService() {
> +    if (!this._sourceMapURLService) {
> +      this._sourceMapURLService = this.toolbox.sourceMapURLService;

Perhaps add a comment here that says that `this.toolbox.sourceMapURLService` is itself a lazy getter.
Otherwise, it's hard to understand why we would go through such trouble to lazily get it here too, if that service has already been initialized by the toolbox.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c31a27e8b51a
Lazy load the sourceMapURLService from the rule editor. r=pbro

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c31a27e8b51a