1463704 - Closing 'Library' window cancels all downloads without warning

Status: NEW

(Toolkit :: Downloads API, defect, P3)

Description

[mthw0]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20100101

Steps to reproduce:

When Library window is closed and a download is still in progress no warning is shown and download is interrupted.



Expected results:

There should be a warning preventing me from accidentaly cancelling my downloads if 'Library' is the only window open from Firefox

Comment 1

[Gingerbread Man]

If Firefox exits without warning when you have running downloads, they should be resumable. If the downloads don't resume when next starting Firefox, please provide at least one example download link.

Comment 2

[mthw0]

You can try this one:
https://git-scm.com/download/win
After starting Firefox again the download is listed as failed.

Comment 3

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
20180516032328

Can you reproduce the issue in a brand new profile?
https://support.mozilla.com/kb/profile-manager-create-and-remove-firefox-profiles

Trying to exit while downloading the following from the page at comment 2 results in the usual warning for me.
https://github.com/git-for-windows/git/releases/download/v2.17.0.windows.1/Git-2.17.0-64-bit.exe


Cancel All Downloads?

If you exit now, 1 download will be canceled. Are you sure you want to exit?

[Cancel 1 Download] [Don't Exit]

Comment 4

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
20180523100147

Sorry about the previous comment. The issue is reproducible if the Library window is the last Firefox window to close:

1. Open the Library window ("Show All Bookmarks" / Ctrl+Shift+B).
2. https://git-scm.com/download/win
3. Start downloading a file there, e.g.
https://github.com/git-for-windows/git/releases/download/v2.17.0.windows.1/Git-2.17.0-64-bit.exe
4. Close the main Firefox window.
5. Close the Library window.

Actual results:
Firefox quits with no warning, canceling the download.

Expected results:
The following warning:

Cancel All Downloads?

If you exit now, 1 download will be canceled. Are you sure you want to exit?

[Cancel 1 Download] [Don't Exit]

Comment 5

[mthw0]

Almost 2 years after and still no fix?