Closed
Bug 1463708
Opened 7 years ago
Closed 7 years ago
The theme list padding allows the current theme preview during hover in customize mode
Categories
(Firefox :: Toolbars and Customization, defect, P3)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 62
People
(Reporter: JuliaC, Assigned: Gijs)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
[Affected versions]:
- 62.0a1 (2018-05-22)
- 61.0b7 build1 (20180521110957)
- 60.0.1 build2 (20180516032328)
[Affected platforms]:
- Windows 10x64
- macOS 10.13.4
- Ubuntu 16.04 x64
[Steps to reproduce]:
1. Launch Firefox
2. Enter the "Customize..." mode
3. Open the Themes drop down and set the Dark theme
4. Reopen the Themes drop down and hover every list item
- pay attention to the areas that delimit each list item and to the preview process
[Expected result]:
- The user can smoothly hover each theme from the list
- The preview process is displayed without any glitches and properly indicates the hovered items
[Actual result]:
- The border between each theme allows the current theme preview after each hovered theme (see the screencast https://drive.google.com/file/d/1UXo5A-DI-6iAmgSgUb3fdcNO4EAnXm_3/view?usp=sharing)
- This fact can be confusing for the users
- If hovering the theme list quickly enough, the behaviour is just like a glitch and it can be annoying
[Regression range]:
- This is not a recent regression, as it reproducible all the way back to 38.0a1 (2015-02-07)
Assignee | ||
Comment 1•7 years ago
|
||
This seems most severe when the selected theme is dark and you hover between two light themes (or vice versa) but I agree it doesn't look great and fixing it would improve things. Marking as P3, though wontfixing for 60/61 as it doesn't seem severe enough to backport to those branches.
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8986291 [details]
Bug 1463708 - only reset previews when leaving the panel,
https://reviewboard.mozilla.org/r/251666/#review258180
Thanks!
::: browser/components/customizableui/CustomizeMode.jsm:1422
(Diff revision 1)
> });
> panel.insertBefore(button, recommendedLabel);
> }
>
> + function panelMouseOut(e) {
> + if (e.explicitOriginalTarget == panel) {
Why are you doing this check? Can you please add a short comment why this is necessary? :)
Attachment #8986291 -
Flags: review?(jhofmann) → review+
Comment hidden (mozreview-request) |
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b70d2c476c33
only reset previews when leaving the panel, r=johannh
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment 6•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•7 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•