Closed
Bug 1463717
Opened 6 years ago
Closed 6 years ago
AttachFinishedCompilations is potentially inefficient for large numbers of compilations
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
4.34 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
AttachFinishedCompilations calls GetFinishedBuilder in a loop to find all compilations that need to be attached, but the latter does a linear scan of the finished list. This could be improved by processing all of the finished compilations in one go.
Assignee | ||
Comment 1•6 years ago
|
||
Patch to move all finished compilations to lazy link list in one go. Eagerly linking the excess compilations drops the helper thread lock so we need to loop round and recheck if that happens.
Attachment #8979914 -
Flags: review?(jdemooij)
Comment 2•6 years ago
|
||
Comment on attachment 8979914 [details] [diff] [review] bug1463717-attach-finished Review of attachment 8979914 [details] [diff] [review]: ----------------------------------------------------------------- Nice find, thanks for fixing.
Attachment #8979914 -
Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/61c4b01ed3c0 Move all finsished builders to lazy link list to avoid possible quadratic behaviour r=jandem
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/61c4b01ed3c0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•