Closed
Bug 1463758
Opened 6 years ago
Closed 6 years ago
RacyFeatures has no reason to use sequentially consistent memory ordering.
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
And given it's hot we may as well make it fast.
|
||
Comment 1•6 years ago
|
||
I agree.
| Comment hidden (mozreview-request) |
|
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8979963 [details] Bug 1463758: Don't use sequentially consistent atomic operations in RacyFeatures. https://reviewboard.mozilla.org/r/246160/#review252214 You're right. This is already declared as a "racy", "don't make any assumptions about any other state being consistent with it" field, so Relaxed is the right memory ordering for it.
Attachment #8979963 -
Flags: review?(mstange) → review+
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/dee01445e642 Don't use sequentially consistent atomic operations in RacyFeatures. r=mstange
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dee01445e642
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•