1463758 - RacyFeatures has no reason to use sequentially consistent memory ordering.

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

And given it's hot we may as well make it fast.

Comment 1

[Markus Stange [:mstange]]

I agree.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1463758: Don't use sequentially consistent atomic operations in RacyFeatures.

Relaxed is more than enough for this use.

Review commit: https://reviewboard.mozilla.org/r/246160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246160/

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8979963 [details]
Bug 1463758: Don't use sequentially consistent atomic operations in RacyFeatures.

https://reviewboard.mozilla.org/r/246160/#review252214

You're right. This is already declared as a "racy", "don't make any assumptions about any other state being consistent with it" field, so Relaxed is the right memory ordering for it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dee01445e642
Don't use sequentially consistent atomic operations in RacyFeatures. r=mstange

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/dee01445e642