Closed Bug 1463782 Opened 5 years ago Closed 5 years ago

Remote Settings throws out entries for toolkit@mozilla.org

Categories

(Toolkit :: Blocklist Policy Requests, enhancement)

Product:
Toolkit
Component:
Blocklist Policy Requests
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Bug 1463782 - allow toolkit apps in kinto blocklist,
59 bytes, text/x-review-board-request
leplatrem
: review+
Details 
Client-side tests assume that plugin/add-on items can be blocked for specific toolkit (ie gecko) versions. It seems this is not possible with the code in blocklist-clients.js as written, because it doesn't recognize the `toolkit@mozilla.org` ID, notices it doesn't match the app ID, and throws it away, without checking the toolkit version.

We should change this.
I also removed the checks on minVersion because they too shouldn't be happening, and I don't think are currently happening on the server (per this comment https://github.com/mozilla-services/amo2kinto/pull/74/files#diff-7e59bae2f68a1c439e6c151596508cdeR72 ).

I should probably have picked this up as part of the review in bug 1458920... :-(
Blocks: 1458920
Comment on attachment 8980011 [details]
Bug 1463782 - allow toolkit apps in kinto blocklist,

https://reviewboard.mozilla.org/r/246190/#review252336

::: services/common/tests/unit/test_blocklist_clients.js:553
(Diff revision 1)
>              "guid": "xpcshell@tests.mozilla.org",
> -            "minVersion": "99999"
> +            "maxVersion": "20"
>            }],
>          }],
>          "id": "86771771-e803-4006-95e9-c9275d58b3d1"
>        }]})

Here it could be worth changing one of the record that matches on `guid: xpcshell@tests.mozilla.org` to `guid: toolkit@mozilla.org`, just to go through that new condition.
Attachment #8980011 - Flags: review?(mathieu) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8a9d325e3285
allow toolkit apps in kinto blocklist, r=leplatrem
https://hg.mozilla.org/mozilla-central/rev/8a9d325e3285
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.