59 bytes, text/x-review-board-request
Client-side tests assume that plugin/add-on items can be blocked for specific toolkit (ie gecko) versions. It seems this is not possible with the code in blocklist-clients.js as written, because it doesn't recognize the `email@example.com` ID, notices it doesn't match the app ID, and throws it away, without checking the toolkit version. We should change this.
I also removed the checks on minVersion because they too shouldn't be happening, and I don't think are currently happening on the server (per this comment https://github.com/mozilla-services/amo2kinto/pull/74/files#diff-7e59bae2f68a1c439e6c151596508cdeR72 ). I should probably have picked this up as part of the review in bug 1458920... :-(
Comment on attachment 8980011 [details] Bug 1463782 - allow toolkit apps in kinto blocklist, https://reviewboard.mozilla.org/r/246190/#review252336 ::: services/common/tests/unit/test_blocklist_clients.js:553 (Diff revision 1) > "guid": "firstname.lastname@example.org", > - "minVersion": "99999" > + "maxVersion": "20" > }], > }], > "id": "86771771-e803-4006-95e9-c9275d58b3d1" > }]}) Here it could be worth changing one of the record that matches on `guid: email@example.com` to `guid: firstname.lastname@example.org`, just to go through that new condition.
Attachment #8980011 - Flags: review?(mathieu) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8a9d325e3285 allow toolkit apps in kinto blocklist, r=leplatrem
You need to log in before you can comment on or make changes to this bug.