1463805 - Update artifact automation configs to not include the "clobber" step

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Chris Manchester (limited bugmail, email directly)]

Due to a quirk of how mozharness build variant configs interact with taskcluster, we've been inadvertently running the "clobber" step in automation artifact builds. This recently stopped being a no-op due to an unrelated change, so we're blowing away our checkout and the builds are failing.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1463805 - Update mozharness artifact build configs not to include the "clobber" step.

Review commit: https://reviewboard.mozilla.org/r/246226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246226/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8980063 [details]
Bug 1463805 - Update mozharness artifact build configs not to include the "clobber" step.

https://reviewboard.mozilla.org/r/246226/#review252344

I can buy that blowing away the srcdir prior to doing the build is bad, but why is this same behavior not a problem for all the other configs?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a882645f3abc
Update mozharness artifact build configs not to include the "clobber" step. r=froydnj

Comment 4

[Chris Manchester (limited bugmail, email directly)]

(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8980063 [details]
> Bug 1463805 - Update mozharness artifact build configs not to include the
> "clobber" step.
> 
> https://reviewboard.mozilla.org/r/246226/#review252344
> 
> I can buy that blowing away the srcdir prior to doing the build is bad, but
> why is this same behavior not a problem for all the other configs?

For most builds TC overrides the set of actions with MOZHARNESS_ACTIONS, but for forced artifact builds we don't let this happen, so we run the clobber step. This apparently went unnoticed because the "clobber()" implementation invoked ended up being a no-op, until bug 1237182 shuffled mixins enough to make it no longer a no-op.

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/a882645f3abc