Closed Bug 1463834 Opened 6 years ago Closed 6 years ago

Vendor python-hglib via |mach vendor python|

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
3 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: davehunt, Assigned: scarrillo, Mentored)

References

Details

Attachments

(1 file)

Bug 1463834 - vendored hglib, updated to python-hglib
59 bytes, text/x-review-board-request
davehunt
: review+
Details 
Whilst working on bug 1346026 I noticed that we've vendored a package named 'python-hglib' as 'hglib'. The new |mach vendor python| command ensures that packages are vendored using their official name.

For this bug, you will need to clone mozilla-central and run the following:

$ mach vendor python python-hglib==2.4

This will vendor the python-hglib package that matches the existing vendored package (at the time of writing) introduced in bug 1393242. It will however be located in third_party/python/python-hglib.

You will then need to remove the existing vendored package in third_party/python/hglib, and ensure that any source code referencing the old location is updated.
Assignee: nobody → scarrillo
Attachment #8982391 - Flags: review?(dave.hunt)
Blocks: 1466211
Comment on attachment 8982391 [details]
Bug 1463834 - vendored hglib, updated to python-hglib

https://reviewboard.mozilla.org/r/248332/#review254844

Looks great, thanks!
Attachment #8982391 - Flags: review?(dave.hunt) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4146b1ddbb34
vendored hglib, updated to python-hglib r=davehunt
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/4146b1ddbb34
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Keywords: good-first-bug
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.