1463892 - Improve example for tabs.get()

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: Add-ons, enhancement, P1)

Description

[rugk]

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: unspecified
 Technical Contact: 

:: Details

The example at the bottom of the page, first get's the tabs.Tab object of the current tab. So far, so good. It then passes it to "getInfoForTab", which itself just sues the tab ID and passes it to browser.tabs.get() in order to get information about the current tab again.

The problem: browser.tabs.get() also just returns a tabs.Tab object. So actually, it does not return a different object. Thus, the example just queries the object two times, before it does something with it.

I think this is… to put it in this way… bad coding style or, shoudl I say, just useless? At least such an example should nopt be in the official docs, IMHO.

Comment 1

[Will Bamberg [:wbamberg]]

I've updated this example to fetch a tab on tabs.onActivated, which just passes in a tab ID. Does this look better to you?

Comment 2

[rugk]

Yeah, I'd say it is fine. :)