Closed
Bug 1463893
Opened 6 years ago
Closed 6 years ago
make nsThreadStartupEvent's destructor private
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.65 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
Whatever compiler bugs required this destructor to be public have either long since been fixed, or the compilers themselves have become obsolete. Plus we get to fix a wrong comment and make another class final in the process.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8980153 -
Flags: review?(erahm)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8980153 [details] [diff] [review] make nsThreadStartupEvent's destructor private Review of attachment 8980153 [details] [diff] [review]: ----------------------------------------------------------------- xlC_r on AIX! r=me
Attachment #8980153 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8239a2ac64c5 make nsThreadStartupEvent's destructor private; r=erahm
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8239a2ac64c5
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•