Closed Bug 1463921 Opened 4 years ago Closed 4 years ago
Error: STOP! js/src/old-configure has changed and needs to be run again
59 bytes, text/x-review-board-request
When I update the local repo today and try to build, I got an error: > 0:02.53 STOP! js/src/old-configure has changed and needs to be run again. > 0:02.55 Please rerun it. > 0:02.57 To ignore this message, touch "obj-firefox-opt/js/src/config.status", > 0:02.59 but your build might not succeed. I ran "./mach configure" then build again, the same error shows up again. Why's that?
This probably has something to do with bug 1461836. I will take a look.
Assignee: nobody → cmanchester
(In reply to Chris Manchester (:chmanchester) from comment #1) > This probably has something to do with bug 1461836. I will take a look. I thought so too, but I can reproduce on a version before that bug: $ ./mach configure $ touch js/src/old-configure $ ./mach build # Gets the STOP! error message $ ./mach configure # This doesn't update objdir/js/src/config.status, but does update objdir/config.status $ ./mach build # Still gets the STOP! error message
I guess subconfigure.py checks $srcdir/configure when deciding to re-run the js configure, so bug 1461836 probably caused this by touching $srcdir/configure less.
This patch just changes that to depend on "$srcdir/old-configure" instead, which is pretty much the status quo.
4 years ago
Attachment #8980139 - Flags: review?(mshal) → review?(core-build-config-reviews)
Attachment #8980139 - Flags: review?(core-build-config-reviews) → review?(gps)
Comment on attachment 8980139 [details] Bug 1463921 - Re-run js configure when js/src/old-configure changes. https://reviewboard.mozilla.org/r/246298/#review252426 I ran into similar issues when developing similar patches. I /think/ this change is fine. I'd feel better if we consulted the mtimes of both `configure` and `old-configure`. But my recollection of the logic is that `configure` and `old-configure` get generated at the same time. So I think this change is fine.
Attachment #8980139 - Flags: review?(gps) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/037424ee08ef Re-run js configure when js/src/old-configure changes. r=gps
You need to log in before you can comment on or make changes to this bug.