1463924 - Remove Dev Edition promo

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It sounds like at some stage a decision was taken to remove the Dev Edition promo, so let's do it.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Just to confirm, Harald do you agree it should be removed?  (Victoria recalls discussing removal with someone, but we're not sure who it was.)

Comment 2

[Victoria Wang [:victoria]]

I'm in favor of removing it because:

- It's a unsolicited content-blocking popup which should only be used for very important (or at least very contextual and helpful) reasons
- It doesn't provide any value to the vast majority of people who are already in the process of using DevTools, and are probably in the middle of fixing some bug, so they are even less interested in installing new software than usual

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1463924 - Remove Dev. Edition promo doorhanger.

Review commit: https://reviewboard.mozilla.org/r/246290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246290/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=57efab50032eb3fa64f98821ce4a9508929f840e

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252458

Looks good to me, thanks Ryan.
For some reason MozReview seems to indicate that they were _changes_ to the dev-edition-logo.png file, but the raw diff do show that it is deleted.

::: commit-message-77c06:1
(Diff revision 1)
> +Bug 1463924 - Remove Dev. Edition promo doorhanger. r=jdescottes

s/jdescottes/nchevobbe, unless you also want Julian to have a look

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252538

We can also delete this reference 

https://searchfox.org/mozilla-central/source/testing/profiles/unittest/user.js#95

Comment 7

[:Harald Kirschner :digitarald]

Yes, this should be removed.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252458

> s/jdescottes/nchevobbe, unless you also want Julian to have a look

Thanks!  I believe auto-land rewrites the reviewers on landing, but I'll change it too just in case!

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252538

Thanks, fixed.

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252458

> Thanks!  I believe auto-land rewrites the reviewers on landing, but I'll change it too just in case!

oh, that's nice !

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246290/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73d696f9e675
Remove Dev. Edition promo doorhanger. r=nchevobbe

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/73d696f9e675