Closed Bug 1463924 Opened 2 years ago Closed 2 years ago

Remove Dev Edition promo

Categories

(DevTools :: General, enhancement, P2)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file)

It sounds like at some stage a decision was taken to remove the Dev Edition promo, so let's do it.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Just to confirm, Harald do you agree it should be removed?  (Victoria recalls discussing removal with someone, but we're not sure who it was.)
Flags: needinfo?(hkirschner)
I'm in favor of removing it because:

- It's a unsolicited content-blocking popup which should only be used for very important (or at least very contextual and helpful) reasons
- It doesn't provide any value to the vast majority of people who are already in the process of using DevTools, and are probably in the middle of fixing some bug, so they are even less interested in installing new software than usual
Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252458

Looks good to me, thanks Ryan.
For some reason MozReview seems to indicate that they were _changes_ to the dev-edition-logo.png file, but the raw diff do show that it is deleted.

::: commit-message-77c06:1
(Diff revision 1)
> +Bug 1463924 - Remove Dev. Edition promo doorhanger. r=jdescottes

s/jdescottes/nchevobbe, unless you also want Julian to have a look
Attachment #8980130 - Flags: review?(nchevobbe) → review+
Yes, this should be removed.
Flags: needinfo?(hkirschner)
Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252458

> s/jdescottes/nchevobbe, unless you also want Julian to have a look

Thanks!  I believe auto-land rewrites the reviewers on landing, but I'll change it too just in case!
Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252538

Thanks, fixed.
Comment on attachment 8980130 [details]
Bug 1463924 - Remove Dev. Edition promo doorhanger.

https://reviewboard.mozilla.org/r/246290/#review252458

> Thanks!  I believe auto-land rewrites the reviewers on landing, but I'll change it too just in case!

oh, that's nice !
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/73d696f9e675
Remove Dev. Edition promo doorhanger. r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/73d696f9e675
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.