Closed Bug 1463978 Opened 2 years ago Closed 2 years ago
"unreachable pattern" warning for background-attachment
59 bytes, text/x-review-board-request
There is a warning shows up every time when recompiling style crate: > warning: unreachable pattern > --> obj-firefox-opt/toolkit/library\x86_64-pc-windows-msvc\debug\build\style-1d083b445dd7b1b6\out/gecko_properties.rs:15562:25 > | > 15562 | _ => panic!("Found unexpected value in style struct for background_attachment property"), > | ^ > | > = note: #[warn(unreachable_patterns)] on by default We should fix it...
Comment on attachment 8980170 [details] Bug 1463978 - Don't generate catch-all branch if a image layer keyword value is exhaustive. https://reviewboard.mozilla.org/r/246324/#review252492 Stealing, thanks for this, I was too lazy when I first saw it :)
Attachment #8980170 - Flags: review+
Attachment #8980170 - Flags: review?(cam)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f6f9930363f2 Don't generate catch-all branch if a image layer keyword value is exhaustive. r=emilio
You need to log in before you can comment on or make changes to this bug.