Closed Bug 1463978 Opened 2 years ago Closed 2 years ago

"unreachable pattern" warning for background-attachment

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

There is a warning shows up every time when recompiling style crate:
> warning: unreachable pattern
>      --> obj-firefox-opt/toolkit/library\x86_64-pc-windows-msvc\debug\build\style-1d083b445dd7b1b6\out/gecko_properties.rs:15562:25
>       |
> 15562 |                         _ => panic!("Found unexpected value in style struct for background_attachment property"),
>       |                         ^
>       |
>       = note: #[warn(unreachable_patterns)] on by default

We should fix it...
Priority: -- → P3
Comment on attachment 8980170 [details]
Bug 1463978 - Don't generate catch-all branch if a image layer keyword value is exhaustive.

https://reviewboard.mozilla.org/r/246324/#review252492

Stealing, thanks for this, I was too lazy when I first saw it :)
Attachment #8980170 - Flags: review+
Attachment #8980170 - Flags: review?(cam)
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6f9930363f2
Don't generate catch-all branch if a image layer keyword value is exhaustive. r=emilio
https://hg.mozilla.org/mozilla-central/rev/f6f9930363f2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.