1464002 - mips Atomics compareExchange

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[qiaopengcheng]

User Agent: Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20180523145036

Steps to reproduce:

using the javascript function of Atomics.compareExchange.


Actual results:

javascript function of Atomics.compareExchange can not work normally when the typearray is like Int8Array, Uint8Array...


Expected results:

javascript function of Atomics.compareExchange should work normally.

Comment 1

[qiaopengcheng]

Attachment: mips Atomics compareExchange

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc575c33a610
Implementation error of Atomics.compareExchange on mips. r=lth

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/cc575c33a610

Comment 5

[Dragan Mladjenovic]

Comment on attachment 8980203 [details] [diff] [review]
mips  Atomics compareExchange

Approval Request Comment
[Feature/Bug causing the regression]: 1420838
[User impact if declined]: Affects mips64/mips32 platforms.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: No. 
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Affects only MIPS code.
[String changes made/needed]:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8980203 [details] [diff] [review]
mips  Atomics compareExchange

MIPS-only change. Approved for 61.0b12.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c7746c6e3a3f