Closed Bug 1464075 Opened 2 years ago Closed 2 years ago

Missing type guard on WebAssembly.Global

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jseward, Assigned: jseward)

References

Details

Attachments

(1 file)

Found whilst trying to import WebAssembly mutable-global tests.  It appears
that there is no check that verifies that the actual type of an imported global
is what is expected.
Attachment #8980304 - Flags: review?(lhansen)
Comment on attachment 8980304 [details] [diff] [review]
bug1464075-WAG-missing-type-guard-1.diff

Review of attachment 8980304 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, ship it.
Attachment #8980304 - Flags: review?(lhansen) → review+
Could you a shell test case to globals.js that would've caught this?
(In reply to Luke Wagner [:luke] from comment #3)
> Could you a shell test case to globals.js that would've caught this?

The test case is in bug 1452588 (Import WebAssembly reference tests for
import/export of mutable globals), which should land in the next couple
of days.  The test will be in the updated jsapi.js.  Indeedy, I discovered
this problem only whilst working to import those tests.

Is that OK?  Or do you also want a test in globals.js too? (unclear)
Flags: needinfo?(luke)
Ah, I hadn't made that connection; I guess that's sufficient.
Flags: needinfo?(luke)
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7f93c521713
Missing type guard on WebAssembly.Global.  r=lth.
https://hg.mozilla.org/mozilla-central/rev/e7f93c521713
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee: nobody → jseward
You need to log in before you can comment on or make changes to this bug.