Closed Bug 1464092 Opened 2 years ago Closed 2 years ago

Speed up a bunch of potentially-slow oomTests

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

In bug 1401842 I discovered that a test which called newGlobal() inside oomTest() could be made significantly faster by calling newGlobal({sameZoneAs: this}) instead.

This is a bug to do that for other tests where possible.
Patch to apply the same fix to other tests which didn't obviously depend on the same-zoneness of the new global.  Time to run the set of tests in --tbpl mode went  from 167.9s to 106.8s for an optdebug build on my machine.
Attachment #8980363 - Flags: review?(jdemooij)
Attachment #8980363 - Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/107ae32fe44f
Speed up some more oomTests that may be taking a long time r=jandem
https://hg.mozilla.org/mozilla-central/rev/107ae32fe44f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
See Also: → 1401842
You need to log in before you can comment on or make changes to this bug.