Update Phabricator to not automatically promote revisions to needs-review from draft status and let Feed daemon perform the step

RESOLVED FIXED

Status

enhancement
P2
normal
RESOLVED FIXED
Last year
4 months ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

({conduit-triaged})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently draft revisions are hidden from the feed until accepted and set to needs-review state. Therefore BMO cannot see them and do not update the permissions, etc. With a custom build step we can extend the current "Make HTTP
 Request" build step to publish a feed story for a draft revision and then update BMO to also look for that story when deciding what changes are needed to the revision.

dkl
How is this related to bug 1462685?  Dep, blocker, unrelated, or dupe? :)
Flags: needinfo?(dkl)
(In reply to Mark Côté [:mcote] from comment #1)
> How is this related to bug 1462685?  Dep, blocker, unrelated, or dupe? :)

It is related but not a blocker. This is the improvement to the currently implementation we discussed in last weeks conduit meeting that removes the need to make an extra call to the BMO API to add a build target id to a BMO table.

It will add a new feed entry when a draft is created that BMO can trigger off of and update the revision. After updating the revision, it will tell Harbormaster the build was successful if the revision is in a DRAFT state.

dkl
Flags: needinfo?(dkl)
Summary: Need custom harbormaster build step for publishing feed story when a revision enters draft state → Update Phabricator to not automatically promote revisions to needs-review from draft status and let Feed daemon perform the step
Blocks: 1503270
Keywords: conduit-story
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.