Closed
Bug 1464182
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11146 - PaymentHandler: Fix a crash when creating event object with empty data
Categories
(Core :: DOM: Web Payments, enhancement, P4)
Core
DOM: Web Payments
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11146 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/11146 Details from upstream follow. Jinho Bang <jinho.bang@samsung.com> wrote: > PaymentHandler: Fix a crash when creating event object with empty data > > The following codes cause crashes in current implementation. > - new CanMakePaymentEvent("canmakepaymentevent", {}); > - new PaymentRequestEvent("paymentrequestevent", {}); > > This patch fixes the problem and fixes/adds WPT tests. > > Bug: none > Change-Id: I95375f1148d69a17075d393990e3726ad2bf1cf3 > > Reviewed-on: https://chromium-review.googlesource.com/1070957 > WPT-Export-Revision: d0a2f58181948ea564340349c0780768a2c43800
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=05bac2ec4e4364b8a8e1c3a25242f5fc75c3df70
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f281b66a7c44806375432f91e7b2b013fc689c86
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9ddc56bdcb6b2bc7bb4f80593fe5896a3d0aae3
Assignee | ||
Comment 4•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=0846ee19a535247c682920a1b54d428926c11276
Assignee | ||
Comment 5•6 years ago
|
||
Ran 6 tests and 14 subtests OK : 6 PASS : 6 FAIL : 8 New tests that have failures or other problems: /payment-handler/can-make-payment-event-constructor.https.serviceworker.html CanMakePaymentEvent can be constructed in service worker.: FAIL CanMakePaymentEvent can be constructed with a CanMakePaymentEventInit, even if not trusted: FAIL CanMakePaymentEvent can be constructed with an EventInitDict, even if not trusted: FAIL CanMakePaymentEvent can be dispatched, even if not trusted: FAIL /payment-handler/payment-request-event-constructor.https.serviceworker.html PaymentRequestEvent can be constructed with a PaymentRequestEventInit, even if not trusted: FAIL PaymentRequestEvent can be constructed with an EventInitDict, even if not trusted: FAIL PaymentRequestEvent can be constucted in service worker.: FAIL PaymentRequestEvent can be dispatched, even if not trusted: FAIL
Assignee | ||
Comment 6•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc9079211b6ee5f9675cede0a70cca879c1b5e87
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/48c118bfefb4 [wpt PR 11146] - PaymentHandler: Fix a crash when creating event object with empty data, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/6991c57a7529 [wpt PR 11146] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/d93ccdd537a6 [wpt PR 11146] - PaymentHandler: Fix a crash when creating event object with empty data, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/b5466bfc4724 [wpt PR 11146] - Update wpt metadata, a=testonly
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d93ccdd537a6 https://hg.mozilla.org/mozilla-central/rev/b5466bfc4724
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•