Closed Bug 1464197 Opened Last year Closed Last year

[wpt-sync] Sync PR 11147 - [css-contain] Disable paint containment in non-atomic inlines

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11147 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/11147
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-contain] Disable paint containment in non-atomic inlines
>  
>  Text from the spec
>  (https://drafts.csswg.org/css-contain/#containment-paint):
>    "... if the element's principal box is a non-atomic inline-level box,
>    paint containment has no effect."
>  
>  The patch disables "contain: paint" in non-atomic inline-level boxes.
>  For that a new method LayoutObject::ShouldApplyPaintContainment()
>  is added, which is used instead of ComputeStyle::ContainsPaint()
>  all around the code.
>  
>  More changes on that new method would be needed to fulfill
>  the rest of requirements from the spec, as paint containment
>  shouldn't apply to internal table and ruby elements for example.
>  
>  Also similar patches for other kind of containment like layout and size
>  are going to be required.
>  
>  Regarding tests this patch makes us pass contain-paint-002.html.
>  On top of that a few extra tests have been added.
>  
>  BUG=843329
>  TEST=external/wpt/css/css-contain/contain-paint-011.html
>  TEST=external/wpt/css/css-contain/contain-paint-012.html
>  TEST=external/wpt/css/css-contain/contain-paint-013.html
>  
>  Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>  Change-Id: I140fad061f5cda14e52451aa8f4bc70c9edede3e
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1071794
>  WPT-Export-Revision: b4a8f272b02d66de693e04605feb97305505801e
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 3 tests
FAIL   : 3

New tests that have failures or other problems:
/css/css-contain/contain-paint-011.html: FAIL
/css/css-contain/contain-paint-012.html: FAIL
/css/css-contain/contain-paint-013.html: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/689157510a21
[wpt PR 11147] - [css-contain] Disable paint containment in non-atomic inlines, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/32596bd377c6
[wpt PR 11147] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/689157510a21
https://hg.mozilla.org/mozilla-central/rev/32596bd377c6
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.