Closed Bug 1464229 Opened Last year Closed Last year

Remove CPU-type attributes from MacOS X implementation of nsIProcess

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

Details

Attachments

(1 file)

The implementation of nsIProcess passes a list of preferred CPU types to posix_spawnp() on Mac. This was done when we had to deal with universal binaries and backwards compatibility with 32-bit x86 and PowerPC executables. We haven't supported those in a while and neither does MacOS X anymore so we should get rid of it.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment on attachment 8980424 [details]
Bug 1464229 - Remove obsolete CPU-selection attributes when creating a new process on MacOS X;

https://reviewboard.mozilla.org/r/246590/#review252720

Watch us have to add this code back when Apple releases the new ARM64 Macs with x86-64 emulation or somesuch.
Attachment #8980424 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Watch us have to add this code back when Apple releases the new ARM64 Macs
> with x86-64 emulation or somesuch.

Hah, that would be fun :) Thanks for the review.
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8574b677039
Remove obsolete CPU-selection attributes when creating a new process on MacOS X; r=froydnj
https://hg.mozilla.org/mozilla-central/rev/a8574b677039
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.