Closed Bug 1464234 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 11150 - [testharness.js] Extend test suite with "variants"

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11150 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/11150
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:
>  [testharness.js] Extend test suite with "variants"
>  
>  Feature description (from modification to `README.md` file):
>  
>  > `testharness.js` is expected to function consistently in a number of
>  > distinct environments. In order to verify this expectation, each
>  > functional test may be executed under a number of distinct conditions.
>  > Within this test suite, these alternate configurations are referred to
>  > as "variants," and defined by the `variants.js` file. This file must
>  > be included in all functional tests and executed before
>  > `testharness.js`.
>  >
>  > However, not all features are available in all environments, and it is
>  > not appropriate to execute the corresponding feature tests in the
>  > unsupported environments. Test files may optionally specify a list of
>  > variants under which they should *not* be executed via the
>  > `wpt-test-skip-variant` meta tag, e.g.:
>  >
>  >     <meta name="wpt-test-skip-variant" content="no-promise">
>  
>  Extend test harness for `testharness.js` with additional validation to
>  ensure that each test is correctly formatted. Introduce a minimal UI to
>  help future contributors discover this new functionality and its
>  motivation.
>  
>  ---
>  
>  @Ms2ger @gsnedders This is in recognition of gh-6266. That consideration is especially important in gh-8748 where we're extending the way `testharness.js` interprets Promise values. This patch will give us more confidence that we're not regressing on the previously-unverified expectation.
PR 11150 applied with additional changes from upstream: 03cf245bbe8a37cc985b663853776474c76a0c40, bfce63b780462a06f65fed7c2033c153ae309c30, d799559e9b1b6a3f1b6d813676eb1fa074a534e5
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
PR 11150 applied with additional changes from upstream: 24d1bbe29fd1ca3ca18e5154d99058be87cb2f24
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae907cfd98e1
[wpt PR 11150] - [testharness.js] Extend test suite with "variants", a=testonly
https://hg.mozilla.org/mozilla-central/rev/ae907cfd98e1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.