Closed
Bug 1464266
Opened 6 years ago
Closed 6 years ago
GCForReason does not suggest being nonincremental
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
|
16.46 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
I found it rather confusing in bug 1459761 that GCForReason implies a nonincremental GC. And I'm not sure the "ForReason" part is all that important, given that it requires a reason argument.
|
Assignee | |
Comment 1•6 years ago
|
||
What do you think of renaming it?
Attachment #8980453 -
Flags: review?(jcoppeard)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8980453 [details] [diff] [review] Rename GCForReason to NonIncrementalGC Review of attachment 8980453 [details] [diff] [review]: ----------------------------------------------------------------- I think that's a great idea.
Attachment #8980453 -
Flags: review?(jcoppeard) → review+
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
||
Updated•6 years ago
|
Component: JavaScript Engine → JavaScript: GC
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0025e7906c15 Rename GCForReason to NonIncrementalGC, r=jonco
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0025e7906c15
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•