Closed Bug 1464266 Opened Last year Closed Last year

GCForReason does not suggest being nonincremental

Categories

(Core :: JavaScript: GC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

I found it rather confusing in bug 1459761 that GCForReason implies a nonincremental GC. And I'm not sure the "ForReason" part is all that important, given that it requires a reason argument.
What do you think of renaming it?
Attachment #8980453 - Flags: review?(jcoppeard)
Comment on attachment 8980453 [details] [diff] [review]
Rename GCForReason to NonIncrementalGC

Review of attachment 8980453 [details] [diff] [review]:
-----------------------------------------------------------------

I think that's a great idea.
Attachment #8980453 - Flags: review?(jcoppeard) → review+
Priority: -- → P3
Component: JavaScript Engine → JavaScript: GC
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0025e7906c15
Rename GCForReason to NonIncrementalGC, r=jonco
https://hg.mozilla.org/mozilla-central/rev/0025e7906c15
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.