1464346 - Skip changes that were already processed

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement)

Description

[Mathieu Leplatre [:leplatrem]]

Currently we fetch the whole list of changes at https://firefox.settings.services.mozilla.com/v1/buckets/monitor/collections/changes/records

But we could also use `?_since=${lastEtag}` to avoid downloading (and analysing) entries that we already processed.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1464346 - Skip RemoteSettings changes that were already processed

Review commit: https://reviewboard.mozilla.org/r/247252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247252/

Comment 2

[Mathieu Leplatre [:leplatrem]]

Comment on attachment 8981152 [details]
Bug 1464346 - Skip RemoteSettings changes that were already processed

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247252/diff/1-2/

Comment 3

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8981152 [details]
Bug 1464346 - Skip RemoteSettings changes that were already processed

https://reviewboard.mozilla.org/r/247252/#review255806

This looks good - I'm keen to ensure that we don't get regressions from modifying the update behaviour; can we get some QA on this (not sure who would look at this usually)?

Comment 4

[Mathieu Leplatre [:leplatrem]]

Thanks!

I checked using about:remotesettings and about:config that we obtain the expected behaviour. I also checked that the CDN caches the responses with ?_since querystrings.

Regarding QA, we are putting in place a validation plan with the Product Integrity team. And it does not concern this change only but the whole RemoteSettings solution. [0]

Unfortunately, it's too table to include this validation plan for the 62 train. 

I'm pretty sure this is safe to land this, but we can wait for 63 if that makes you more comfortable.

[0] https://docs.google.com/document/d/1wqEAiRYQmy1IRSlGc4XQV-tEsK_3KALGeI1Nsn1BPiI/edit#heading=h.4cbo7dbq460e

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62f9aa66e244
Skip RemoteSettings changes that were already processed r=mgoodwin

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/62f9aa66e244