[Tracking Requested - why for this release]: Central as Beta simulation - https://treeherder.mozilla.org/#/jobs?repo=try&revision=0328fc58c863d252d26b33c2388a0fdb89329901&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=180220254 Caused from bug 1464128. Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=180219181&repo=try&lineNumber=32411
I'll definitely address this, but I want to figure out why this isn't doing the right thing before changing anything. It makes no sense: NIGHTLY_BUILD is set unconditionally at https://searchfox.org/mozilla-central/rev/ce86c6c0472d5021ef693cf99abaaa0644c89e55/build/moz.configure/init.configure#1043 but we're failing to find it in buildconfig.substs at https://searchfox.org/mozilla-central/rev/ce86c6c0472d5021ef693cf99abaaa0644c89e55/browser/locales/generate_bookmarks.py#32 That doesn't make any sense to me. I can, of course, `.get(..., False)` or whatever, but I want to understand why buildconfig.substs appears to be lying to me. Update from dmajor: apparently this is _not_ set unconditionally.
OK, this really does need the `.get(..., False)` work-around. I'll get to it.
I wonder if we shouldn't do the more general thing of making buildconfig.substs essentially work like moz.build CONFIG, and never throw KeyError.
(In reply to Mike Hommey [:glandium] from comment #4) > I wonder if we shouldn't do the more general thing of making > buildconfig.substs essentially work like moz.build CONFIG, and never throw > KeyError. I think we should, but not in this ticket -- it's follow-up :)
Triaging, assigning to nalexander since he wrote the patches for this bug.
Assignee: nobody → nalexander
Attachment #8980800 - Flags: review?(core-build-config-reviews) → review?(gps)
Comment on attachment 8980800 [details] Bug 1464381 - Fix check for NIGHTLY_BUILD. https://reviewboard.mozilla.org/r/246970/#review253694
Attachment #8980800 - Flags: review?(gps) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/eaefe57724c7 Fix check for NIGHTLY_BUILD. r=gps
We have verified that this issue is fixed with today's Beta Simulation, link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed376ac1d1c4617b98d720c832dded991ef6bd61&selectedJob=180858976
(In reply to Raul Gurzau (:RaulGurzau) from comment #10) > We have verified that this issue is fixed with today's Beta Simulation, > link: > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=ed376ac1d1c4617b98d720c832dded991ef6bd61&selectedJob=1 > 80858976 Thanks Raul. Sorry for the run-around!
You need to log in before you can comment on or make changes to this bug.