Closed Bug 1464381 Opened 3 years ago Closed 3 years ago

KeyError: u"'NIGHTLY_BUILD'" from bug 1464128 when Gecko 62 merges to Beta on 2018-06-14

Categories

(Firefox Build System :: General, defect)

3 Branch
defect
Not set
normal

Tracking

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox60 unaffected, firefox61 unaffected, firefox62+ verified)

VERIFIED FIXED
mozilla62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 + verified

People

(Reporter: bogdan_tara, Assigned: nalexander)

References

Details

Attachments

(1 file)

I'll definitely address this, but I want to figure out why this isn't doing the right thing before changing anything.  It makes no sense:

NIGHTLY_BUILD is set unconditionally at https://searchfox.org/mozilla-central/rev/ce86c6c0472d5021ef693cf99abaaa0644c89e55/build/moz.configure/init.configure#1043

but we're failing to find it in buildconfig.substs at

https://searchfox.org/mozilla-central/rev/ce86c6c0472d5021ef693cf99abaaa0644c89e55/browser/locales/generate_bookmarks.py#32

That doesn't make any sense to me.  I can, of course, `.get(..., False)` or whatever, but I want to understand why buildconfig.substs appears to be lying to me.

Update from dmajor: apparently this is _not_ set unconditionally.
Flags: needinfo?(nalexander)
OK, this really does need the `.get(..., False)` work-around.  I'll get to it.
I wonder if we shouldn't do the more general thing of making buildconfig.substs essentially work like moz.build CONFIG, and never throw KeyError.
(In reply to Mike Hommey [:glandium] from comment #4)
> I wonder if we shouldn't do the more general thing of making
> buildconfig.substs essentially work like moz.build CONFIG, and never throw
> KeyError.

I think we should, but not in this ticket -- it's follow-up :)
Triaging, assigning to nalexander since he wrote the patches for this bug.
Assignee: nobody → nalexander
Attachment #8980800 - Flags: review?(core-build-config-reviews) → review?(gps)
Comment on attachment 8980800 [details]
Bug 1464381 - Fix check for NIGHTLY_BUILD.

https://reviewboard.mozilla.org/r/246970/#review253694
Attachment #8980800 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eaefe57724c7
Fix check for NIGHTLY_BUILD. r=gps
https://hg.mozilla.org/mozilla-central/rev/eaefe57724c7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
We have verified that this issue is fixed with today's Beta Simulation, link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed376ac1d1c4617b98d720c832dded991ef6bd61&selectedJob=180858976
Status: RESOLVED → VERIFIED
(In reply to Raul Gurzau (:RaulGurzau) from comment #10)
> We have verified that this issue is fixed with today's Beta Simulation,
> link:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=ed376ac1d1c4617b98d720c832dded991ef6bd61&selectedJob=1
> 80858976

Thanks Raul.  Sorry for the run-around!
Belatedly tracking, so that if this reopens it'll show up on our queries.
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.