Closed Bug 1464396 Opened 3 years ago Closed 3 years ago

Navigation between <body> and another element breaks the animation grid

Categories

(DevTools :: Inspector: Animations, defect, P3)

Product:
DevTools
Component:
Inspector: Animations
Type:
defect

Tracking

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox60 unaffected, firefox61 disabled, firefox62 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 62
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- disabled
firefox62 --- verified

People

(Reporter: gpalko, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Keywords: regression, regressionwindow-wanted)

Attachments

(4 files, 3 obsolete files)

grid.PNG
41.30 KB, image/png
Details
Bug 1464396 - Part 1: Hold all animation's created time.
59 bytes, text/x-review-board-request
pbro
: review+
Details
Bug 1464396 - Part 2: Update current time at first.
59 bytes, text/x-review-board-request
pbro
: review+
Details
Bug 1464396 - Part 3: Add whether the created time of animation unchanged even if change node.
59 bytes, text/x-review-board-request
pbro
: review+
Details
Attached image grid.PNG — 
[Environments:]
Windows 10, Windows 7, Ubuntu 16.04, OsX10.12
62.0a1 2018-05-25

[Steps:]
1. Open Firefox and open a new tab with https://rawgit.com/dadaa/3b73f847427025b51ba1ab7333013d0c/raw/77f3f0bb884875a179c3407f73bf8a8dd54751c9/doc_custom_playback_rate.html
2. Press F12 and select Animations tab.
3. Select <body> and press Pause on the animation player.
4. Select a div
5. Select <body> again
6. Repeat steps 4-5 switching between the same div and <body>
7. Inspect the animation grid

[Actual Result:]
The second div's animation bar is moved to the right(see attached screenshot)

[Expected Result:]
The bar's starting point should remain at 0.0s 

[Note:]
On Fx 62.0a1 20180513220424, this issue is not reproducible.
On Fx 61 (old animation inspector), the problem is not reproducible.
Assignee: nobody → dakatsuka
Status: NEW → ASSIGNED
Priority: -- → P3
Attachment #8980635 - Attachment is obsolete: true
Attachment #8980635 - Flags: review?(pbrosset)
Attachment #8980636 - Attachment is obsolete: true
Attachment #8980636 - Flags: review?(pbrosset)
Attachment #8980637 - Attachment is obsolete: true
Attachment #8980637 - Flags: review?(pbrosset)
Comment on attachment 8981036 [details]
Bug 1464396 - Part 1: Hold all animation's created time.

https://reviewboard.mozilla.org/r/247148/#review253248

::: devtools/server/actors/animation.js:968
(Diff revision 1)
> +  },
> +
> +  /**
> +   * Update all animation created time map.
> +   */
> +  updateCreatedTimeMapAll() {

I suggest renaming this to `updateAllAnimationsCreatedTime`

::: devtools/server/actors/animation.js:971
(Diff revision 1)
> +   * Update all animation created time map.
> +   */
> +  updateCreatedTimeMapAll() {
> +    const currentAnimations = this.getAllAnimations(this.tabActor.window.document);
> +
> +    // Remove invalid animation.

Remove invalid animation*s*

::: devtools/server/actors/animation.js:988
(Diff revision 1)
> +  /**
> +   * Update animation created time map.
> +   *
> +   * @param {Object} animation
> +   */
> +  updateCreatedTimeMap(animation) {

I suggest renaming this to `updateAnimationCreatedTime`
Attachment #8981036 - Flags: review?(pbrosset) → review+
Comment on attachment 8981037 [details]
Bug 1464396 - Part 2: Update current time at first.

https://reviewboard.mozilla.org/r/247150/#review253252
Attachment #8981037 - Flags: review?(pbrosset) → review+
Comment on attachment 8981038 [details]
Bug 1464396 - Part 3: Add whether the created time of animation unchanged even if change node.

https://reviewboard.mozilla.org/r/247152/#review253260
Attachment #8981038 - Flags: review?(pbrosset) → review+
Thanks Patrick!

I have updated the patch.
Will land if the try was green.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=36e98ffa330cd73fbaa07b760668b920b10ea535
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/732a958aa5cd
Part 1: Hold all animation's created time. r=pbro
https://hg.mozilla.org/integration/autoland/rev/9353259c9adf
Part 2: Update current time at first. r=pbro
https://hg.mozilla.org/integration/autoland/rev/97aee105338e
Part 3: Add whether the created time of animation unchanged even if change node. r=pbro
Verified as fixed on Nightly 62.0a1(20180610220159) on Win10 x64, Ubuntu 16.04, MacOS 10.12
Status: RESOLVED → VERIFIED
status-firefox62: fixed → verified
Depends on: 1468475
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.