Bug 1464396

Navigation between <body> and another element breaks the animation grid

VERIFIED FIXED in Firefox 62

Get help with this page

Status

Product:

Component:

Type:

defect

Importance:

normal

Status:

VERIFIED FIXED

Reported:

a year ago

Modified:

a year ago

People

(Reporter: gyula.palko, Assigned: daisuke)

Tracking

(Blocks 1 bug, {regression, regressionwindow-wanted})

Version:

Trunk

Target:

Firefox 62

Keywords:

regression, regressionwindow-wanted

Depends on:

1468475

Blocks:

1452971

Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox60 unaffected, firefox61 disabled, firefox62 verified)

Tracking Flags:

Tracking

Status

firefox-esr52

---

unaffected

firefox-esr60

---

unaffected

firefox60

---

unaffected

firefox61

---

disabled

firefox62

---

verified

Details

Attachments

(4 attachments, 3 obsolete attachments)

grid.PNG a year ago Gyula Palko 41.30 KB, image/png		Details
Bug 1464396 - Part 1: Hold all animation's created time. a year ago Daisuke Akatsuka (:daisuke) 59 bytes, text/x-review-board-request		Details
Bug 1464396 - Part 2: Update current time at first. a year ago Daisuke Akatsuka (:daisuke) 59 bytes, text/x-review-board-request		Details
Bug 1464396 - Part 3: Add whether the created time of animation unchanged even if change node. a year ago Daisuke Akatsuka (:daisuke) 59 bytes, text/x-review-board-request		Details
Bug 1464396 - Part 1: Hold all animation's created time. a year ago Daisuke Akatsuka (:daisuke) 59 bytes, text/x-review-board-request	pbro : review+	Details
Bug 1464396 - Part 2: Update current time at first. a year ago Daisuke Akatsuka (:daisuke) 59 bytes, text/x-review-board-request	pbro : review+	Details
Bug 1464396 - Part 3: Add whether the created time of animation unchanged even if change node. a year ago Daisuke Akatsuka (:daisuke) 59 bytes, text/x-review-board-request	pbro : review+	Details

Gyula Palko

Reporter

Description

•

a year ago

Posted image — Details

[Environments:]
Windows 10, Windows 7, Ubuntu 16.04, OsX10.12
62.0a1 2018-05-25

[Steps:]
1. Open Firefox and open a new tab with https://rawgit.com/dadaa/3b73f847427025b51ba1ab7333013d0c/raw/77f3f0bb884875a179c3407f73bf8a8dd54751c9/doc_custom_playback_rate.html
2. Press F12 and select Animations tab.
3. Select <body> and press Pause on the animation player.
4. Select a div
5. Select <body> again
6. Repeat steps 4-5 switching between the same div and <body>
7. Inspect the animation grid

[Actual Result:]
The second div's animation bar is moved to the right(see attached screenshot)

[Expected Result:]
The bar's starting point should remain at 0.0s 

[Note:]
On Fx 62.0a1 20180513220424, this issue is not reproducible.
On Fx 61 (old animation inspector), the problem is not reproducible.

Daisuke Akatsuka (:daisuke)

Assignee

Updated

•

a year ago

Assignee: nobody → dakatsuka

Comment hidden (mozreview-request)

For now, we had taken over the createdTime to new actor from previous actor.
However, if the selected node changed, can not take over that. To resolve this,
hold all animation's createdTime.

Review commit: https://reviewboard.mozilla.org/r/246790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246790/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/246792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246792/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/246794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246794/

Daisuke Akatsuka (:daisuke)

Assignee

Comment 4

•

a year ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf158573b1d206b869b92d2abccd0cc36b1efb84

Gabriel [:gl] (ΦωΦ)

Updated

•

a year ago

Status: NEW → ASSIGNED

Priority: -- → P3

Comment hidden (mozreview-request)

For now, we had taken over the createdTime to new actor from previous actor.
However, if the selected node changed, can not take over that. To resolve this,
hold all animation's createdTime.

Review commit: https://reviewboard.mozilla.org/r/247148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247148/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/247150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247150/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/247152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247152/

Daisuke Akatsuka (:daisuke)

Assignee

Updated

•

a year ago

Attachment #8980635 - Attachment is obsolete: true

Attachment #8980635 - Flags: review?(pbrosset)

Daisuke Akatsuka (:daisuke)

Assignee

Updated

•

a year ago

Attachment #8980636 - Attachment is obsolete: true

Attachment #8980636 - Flags: review?(pbrosset)

Daisuke Akatsuka (:daisuke)

Assignee

Updated

•

a year ago

Attachment #8980637 - Attachment is obsolete: true

Attachment #8980637 - Flags: review?(pbrosset)

Daisuke Akatsuka (:daisuke)

Assignee

Comment 8

•

a year ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ca412724958ba2a503c753ac7137d4fa2ef57e1

Patrick Brosset <:pbro>

Comment 9

•

a year ago

mozreview-review

Comment on attachment 8981036 [details]
Bug 1464396 - Part 1: Hold all animation's created time.

https://reviewboard.mozilla.org/r/247148/#review253248

::: devtools/server/actors/animation.js:968
(Diff revision 1)
> +  },
> +
> +  /**
> +   * Update all animation created time map.
> +   */
> +  updateCreatedTimeMapAll() {

I suggest renaming this to `updateAllAnimationsCreatedTime`

::: devtools/server/actors/animation.js:971
(Diff revision 1)
> +   * Update all animation created time map.
> +   */
> +  updateCreatedTimeMapAll() {
> +    const currentAnimations = this.getAllAnimations(this.tabActor.window.document);
> +
> +    // Remove invalid animation.

Remove invalid animation*s*

::: devtools/server/actors/animation.js:988
(Diff revision 1)
> +  /**
> +   * Update animation created time map.
> +   *
> +   * @param {Object} animation
> +   */
> +  updateCreatedTimeMap(animation) {

I suggest renaming this to `updateAnimationCreatedTime`

Attachment #8981036 - Flags: review?(pbrosset) → review+

Patrick Brosset <:pbro>

Comment 10

•

a year ago

mozreview-review

Comment on attachment 8981037 [details]
Bug 1464396 - Part 2: Update current time at first.

https://reviewboard.mozilla.org/r/247150/#review253252

Attachment #8981037 - Flags: review?(pbrosset) → review+

Patrick Brosset <:pbro>

Comment 11

•

a year ago

mozreview-review

Comment on attachment 8981038 [details]
Bug 1464396 - Part 3: Add whether the created time of animation unchanged even if change node.

https://reviewboard.mozilla.org/r/247152/#review253260

Attachment #8981038 - Flags: review?(pbrosset) → review+

Comment hidden (mozreview-request)

Comment on attachment 8981036 [details]
Bug 1464396 - Part 1: Hold all animation's created time.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247148/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8981037 [details]
Bug 1464396 - Part 2: Update current time at first.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247150/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8981038 [details]
Bug 1464396 - Part 3: Add whether the created time of animation unchanged even if change node.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247152/diff/1-2/

Daisuke Akatsuka (:daisuke)

Assignee

Comment 15

•

a year ago

Thanks Patrick!

I have updated the patch.
Will land if the try was green.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=36e98ffa330cd73fbaa07b760668b920b10ea535

Pulsebot

Comment 16

•

a year ago

Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/732a958aa5cd
Part 1: Hold all animation's created time. r=pbro
https://hg.mozilla.org/integration/autoland/rev/9353259c9adf
Part 2: Update current time at first. r=pbro
https://hg.mozilla.org/integration/autoland/rev/97aee105338e
Part 3: Add whether the created time of animation unchanged even if change node. r=pbro

Stefan Hindli [:stefan_hindli]

Comment 17

•

a year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/732a958aa5cd
https://hg.mozilla.org/mozilla-central/rev/9353259c9adf
https://hg.mozilla.org/mozilla-central/rev/97aee105338e

Status: ASSIGNED → RESOLVED

Last Resolved: a year ago

status-firefox62: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 62

Ryan VanderMeulen [:RyanVM]

Updated

•

a year ago

status-firefox60: --- → unaffected

status-firefox-esr52: --- → unaffected

status-firefox-esr60: --- → unaffected

Gyula Palko

Reporter

Comment 18

•

a year ago

Verified as fixed on Nightly 62.0a1(20180610220159) on Win10 x64, Ubuntu 16.04, MacOS 10.12

Status: RESOLVED → VERIFIED

status-firefox62: fixed → verified

Gyula Palko

Reporter

Updated

•

a year ago

Depends on: 1468475

BMO Automation

Updated

•

a year ago

Product: Firefox → DevTools

You need to log in before you can comment on or make changes to this bug.