1464420 - State change callback takes place after the destructor of AudioCallbackDriver

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P3)

Description

[Alex Chronopoulos [:achronop]]

With cubeb remote, the AudioCallbackDriver::StateCallback (for stop state) takes place after the destructor of AudioCallback.

In order to see the error run it under debugger or add logs in the corresponding methods. In gUM test page make a short audio call. It's more obvious when the last driver is collected, so wait ~30 secs. Check that destructor is executed before the state change callback.

Cubeb stream stop happens in `Shutdown` method here [1] and destruction of the driver a few lines bellow [2]. Since `Shutdown` is a sync method I would expect to see the callback before the return of `Shutdown` method.

[1] https://searchfox.org/mozilla-central/source/dom/media/MediaStreamGraph.cpp#1466
[2] https://searchfox.org/mozilla-central/source/dom/media/MediaStreamGraph.cpp#1478

Comment 1

[Matthew Gregan [:kinetik]]

Fixed by bug 1690718.