Closed Bug 1464476 Opened 2 years ago Closed 2 years ago

Remove devtools.webconsole.autoMultiline preference

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

(Whiteboard: [boogaloo-mvp])

Attachments

(1 file)

Right now we query this preference each time we hit Enter in the editor, to know if we should execute the input content or add a new line.
This pref was added when the feature was created, it is true by default, and we don't expose it in Settings UI.
We talk with bgrins and agreed we can remove it and make it the default.
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [boogaloo-mvp]
Comment on attachment 8981476 [details]
Bug 1464476 - Remove devtools.webconsole.autoMultiline preference; .

https://reviewboard.mozilla.org/r/247584/#review254396

Sorry for the delay.

I am still seeing PREF_AUTO_MULTILINE being used in JSTerm.componentDidMount if (this.props.codeMirrorEnabled)  == true.

Honza
Attachment #8981476 - Flags: review?(odvarko)
true, the 2 patches collided. I'll rebase and push again.
Comment on attachment 8981476 [details]
Bug 1464476 - Remove devtools.webconsole.autoMultiline preference; .

https://reviewboard.mozilla.org/r/247584/#review254620

Looks good to me, thanks Nicolas!

R+, but I am seeing conflict in JSTerm.js when applying the patch on m-c tip

patching file devtools/client/webconsole/components/JSTerm.js
Hunk #1 FAILED at 23
1 out of 3 hunks FAILED -- saving rejects to file devtools/client/webconsole/components/JSTerm.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh multi-line

Honza
Attachment #8981476 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a2f54ae94ca
Remove devtools.webconsole.autoMultiline preference; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/0a2f54ae94ca
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.