Closed Bug 1464492 Opened 6 years ago Closed 6 years ago

canceledOkay arg should be true when starting/stopping timers for A11Y_SERVICE_DURATION.

Categories

(DevTools :: Accessibility Tools, enhancement, P2)

Product:
DevTools
Component:
Accessibility Tools
Type:
enhancement

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(1 file)

1464492 patch
1.24 KB, patch
miker
: review+
Details | Diff | Splinter Review
Bug 1458204 resulted in start/finish throwing an error when we do/don't have the timer already respectively. This is different from previous API so canceledOkay needs to be passed as true.
Attached patch 1464492 patch — — Splinter Review
Attachment #8980706 - Flags: review?(mratcliffe)
Attachment #8980706 - Flags: review?(mratcliffe) → review+
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Keywords: checkin-needed
OS: Unspecified → All
Priority: -- → P2
Hardware: Unspecified → All
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/af369cce3a88 Pass canceledOkay=true when starting/stopping timers for A11Y_SERVICE_DURATION. r=miker
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/af369cce3a88
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: