Closed
Bug 1464517
Opened 7 years ago
Closed 1 month ago
[wpt-sync] Sync PR 11170 - Make sizes-dynamic-001.html not racy.
Categories
(Core :: DOM: Core & HTML, enhancement, P4)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11170 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/w3c/web-platform-tests/pull/11170
Details from upstream follow.
Emilio Cobos Álvarez <emilio@crisal.io> wrote:
> Make sizes-dynamic-001.html not racy.
>
> There's no guarantee the image will be resized before the harness takes the
> screenshot.
>
> Indeed, the image is guaranteed to have the old width / offsetWidth if we were
> to query it from frameLoaded. We do need to wait for the image load task to run.
>
> This makes the test reliable in both Blink and Gecko at least, afaict.
>
> This was reviewed and landed in mozilla-central in bug 1464392, but the sync bot
> seems to have missed it.
>
> MozReview-Commit-ID: 7EDC7jlUScc
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Component: web-platform-tests → DOM
Product: Testing → Core
|
|
Assignee | |
Comment 2•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b934af6fee34b025602f84face4c0c73c6f78e4
|
|
Assignee | |
Comment 3•7 years ago
|
||
Ran 1 tests
PASS : 1
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
|
||
Updated•3 years ago
|
Severity: normal → S3
|
||
Comment 4•1 month ago
|
||
it looks the downstream was completed.
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•