Closed Bug 1464711 Opened 2 years ago Closed 2 years ago

Typo in ExtensionContent Script.requiresCleanup()

Categories

(WebExtensions :: General, enhancement, P1)

62 Branch
enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: zombie, Assigned: rpl)

Details

(Whiteboard: typescript-check)

Attachments

(1 file)

Product: Toolkit → WebExtensions
Hello,
I'm an absolute beginner and would like to work on it.
Devika, thanks for your interest!  Unfortunately, I don't think this is a particularly good first bug.
In particular, removeCss looks like a mis-capitalization of removeCSS so it should probably be changed.  But the fact that everything is working with that typo in place suggests we don't have very good test coverage here so ideally we would improve the test coverage at the same time.
If you're interested in looking into that, feel free but since you say you're an absolute beginner, I would encourage you to look at bugs with the good-first-bug keyword.
Assignee: nobody → lgreco
Priority: -- → P1

This patch fixes the typo in the requiresCleanup getter and adds an additional step
in the automated tests to verify that the scripts created by browser.tabs.removeCSS
are not being added to the content scripts that requires cleanup.

Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/ca8f8514f60d
Fix typo in ExtensionContent script.requiresCleanup getter. r=zombie
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Setting qe-verify-, as this is tested in automation.

Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.