1464711 - Typo in ExtensionContent Script.requiresCleanup()

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Tomislav Jovanovic :zombie]

Typescript check found that property removeCss doesn't exist:

https://searchfox.org/mozilla-central/rev/5a74471/toolkit/components/extensions/ExtensionContent.jsm#306

Comment 1

[Devika Sugathan]

Hello,
I'm an absolute beginner and would like to work on it.

Comment 2

[Andrew Swan [:aswan]]

Devika, thanks for your interest!  Unfortunately, I don't think this is a particularly good first bug.
In particular, removeCss looks like a mis-capitalization of removeCSS so it should probably be changed.  But the fact that everything is working with that typo in place suggests we don't have very good test coverage here so ideally we would improve the test coverage at the same time.
If you're interested in looking into that, feel free but since you say you're an absolute beginner, I would encourage you to look at bugs with the good-first-bug keyword.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1464711 - Fix typo in ExtensionContent script.requiresCleanup getter. r?zombie!

This patch fixes the typo in the requiresCleanup getter and adds an additional step
in the automated tests to verify that the scripts created by browser.tabs.removeCSS
are not being added to the content scripts that requires cleanup.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca8f8514f60d
Fix typo in ExtensionContent script.requiresCleanup getter. r=zombie

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ca8f8514f60d

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Setting qe-verify-, as this is tested in automation.